GNOME Bugzilla – Bug 419279
Mozilla moduletype does not respect MAKE environment variable
Last modified: 2007-04-07 14:37:06 UTC
Please describe the problem: While most module types respect the MAKE environment variable, jhbuild/jhbuild/moduletypes/mozillamodule.py does not during the checkout, update or install operations. If GNU Make is not the system default, this causes problems during these steps. Steps to reproduce: 1. Build GNOME on a system where make(1) is not GNU make 2. Set os.environ['MAKE'] = 'gmake' in jhbuildrc 3. Run 'jhbuild update mozilla'. Actual results: 'make -f client.mk ...', complaining about GNU make-specific syntax Expected results: 'gmake -f client.mk ...' Does this happen every time? Yes. Other information:
Created attachment 84759 [details] [review] Patch to respect MAKE environment variable A small patch which fixes this problem in a similar way to the other module types.
Mozilla module has been switched to the standard <autotools> and <tarball> but I have applied your patch, still useful for older modulesets. Thanks. 2007-04-07 Frederic Peters <fpeters@0d.be> * jhbuild/modtypes/mozillamodule.py: respect MAKE environment variable (closes: #419279, patch by David Adam)