GNOME Bugzilla – Bug 418852
Miscellaneous Camel clean-ups
Last modified: 2007-04-28 01:40:58 UTC
Time for some Camel love! Er, maybe that's not the best way to put it... Here's some miscellaneous clean-ups for Camel. Despite the enormity of the patch, this is all just polishing work. None of it breaks API/ABI or alters the behavior of Camel in any way. - Flesh out <camel/camel.h> to include Camel's entire core API. - Add deprecation guards (CAMEL_DISABLE_DEPRECATED) to functions that are already marked as deprecated in the source code comments. - Deprecate <camel-i18n.h>. Camel being a GLib-based library, it should be using the i18n macros provided by GLib instead of redefining its own. Put deprecation guards around the header file, and use <glib/gi18n-lib.h> internally. (Similar to bug #363033) - On the same note, remove CAMEL_EXPLICIT_TRANSLATION_DOMAIN from all the Makefile.am files. GLib uses GETTEXT_PACKAGE for the translation domain. - Use G_BEGIN_DECLS / G_END_DECLS macros in the header files. It's easier on the eyes and less error-prone than #ifdef __cplusplus extern "C" { #pragma } #endif /* __cplusplus */ ... header file contents ... #ifdef __cplusplus } #endif /* __cplusplus */ - Resurrect the Camel API docs. Apply similar treatment as in bug #413173. The documentation is actually in better shape than I thought, so I just enabled it and added any missing symbols. The actual content still needs a lot of work. - Various other cosmetic changes that highlight my obsessive compulsiveness.
Created attachment 84699 [details] [review] Proposed patch The changes described above touch almost every source code file, so this patch is big. As in, 15,000 lines big. Obviously I don't expect this to be reviewed in detail. Verifying that the patch compiles, that it builds the Camel documentation when properly configured, and perhaps a quick smoke test of Evolution's Mailer should be all that's needed.
Created attachment 84786 [details] [review] Patch for evolution-exchange Include <glib/gi18n-lib.h> instead of <camel/camel-i18n.h>.
Committed the evolution-exchange patch to trunk (revision 1344).
(In reply to comment #1) > Created an attachment (id=84699) [edit] > Proposed patch > > The changes described above touch almost every source code file, so this patch > is big. As in, 15,000 lines big. Obviously I don't expect this to be reviewed > in detail. Verifying that the patch compiles, that it builds the Camel > documentation when properly configured, and perhaps a quick smoke test of > Evolution's Mailer should be all that's needed. > Patch looks good - just a quick glance. ;-) Yes, I agree with you Matthew. Lets commit it and get it churned out by the users.
Committed to Subversion trunk (revision 7720).