GNOME Bugzilla – Bug 418605
Change power statistics label rendering to use pangocairo
Last modified: 2007-05-03 21:49:44 UTC
Please describe the problem: Power statistics label glyphes are broken in non-english locale. Steps to reproduce: 1. run gnome-power-statistics in other locale Actual results: show like this http://ftp.mizi.com/~ganadist/gph-ko.png Expected results: show like this http://ftp.mizi.com/~ganadist/gph-ko-patched.png Does this happen every time? yes Other information: It doesn't specified font face in drawing text. It must change font face in other locale. I'll attach a patch.
Created attachment 84657 [details] [review] set font face that translatable in graph widget This is a patch for gpm 2.18 branch. But it need more works such as using pangocairo for next major release.
I found this problem happen in Ubuntu distribution only. It seems this problem caused ubuntu locale selector. So this is not a bug. But I'll change Severity to enhancement, to rework with pangocairo
Yes, I can reproduce this too. I'll test your patch tonight with different languages, and merge to 2-18 and trunk. If you could work on a pangocairo patch you would be a legend. Thanks.
Created attachment 84666 [details] [review] Patch for statistics label rendering to use pangocairo against 2-18 I changed to use pangocairo for render text in graph. My desktop has no battery, so It might be needed to adjust y-offset in graph.
I've added your first patch to 2-18, thanks; 2007-03-15 Richard Hughes <richard@hughsie.com> * src/gpm-graph-widget.c: (gpm_graph_widget_draw_labels), (gpm_graph_widget_legend_calculate_size), (gpm_graph_widget_draw_graph): Set font face that translatable in graph widget. Patch from Young-Ho Cha, many thanks. The other patch in bugzilla adds pango support, and we should play with it on trunk and then backport it if it proves stable. Fixes #418605 The pango stuff I want to play with on trunk, and then we can look at backporting it. Thanks for doing this, it's appreciated. Richard.
Created attachment 84755 [details] [review] Patch for statistics label rendering to use pangocairo against 2-18 I update a patch. Changes are... adjusted font size adjusted label offset Here are two screenshots that before applied, and applied patch. http://ftp.mizi.com/~ganadist/gpm-cairo.png (before) http://ftp.mizi.com/~ganadist/gpm-pangocairo.png (after)
*** Bug 398368 has been marked as a duplicate of this bug. ***
2007-05-03 Richard Hughes <richard@hughsie.com> * src/gpm-graph-widget.c: Convert gnome-power-statistics to use Pango for text rendering. This is based heavily on a patch by Young-Ho Cha <ganadist@chollian.net> and fixes #418605. Many thanks. Please can you check TRUNK and make sure that this is fixed. Thanks for your help with this.