After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 418073 - Opacity ignored for vtexft
Opacity ignored for vtexft
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.15.x
Other Linux
: Normal major
: ---
Assigned To: Chris Wilson
VTE Maintainers
: 419428 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-03-14 00:38 UTC by Chris Wilson
Modified: 2007-03-17 18:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Check for non-opaque colours as well as an image (3.95 KB, patch)
2007-03-14 00:39 UTC, Chris Wilson
none Details | Review

Description Chris Wilson 2007-03-14 00:38:59 UTC
The xft backend is unusual in that it has an opacity setting. Something I overlooked when deciding that a double-buffered backend could expect GDK to have correctly cleared the pixmap and optimized away the "redundant" clear.

[I could argue that GDK should take an rgba colour and clear the pixmap correctly in the first place...]

This bug was first identified in https://bugs.launchpad.net/ubuntu/+source/vte/+bug/91985.
Comment 1 Chris Wilson 2007-03-14 00:39:52 UTC
Created attachment 84547 [details] [review]
Check for non-opaque colours as well as an image
Comment 2 Chris Wilson 2007-03-16 10:48:05 UTC
r1842: 2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 418073 – Opacity ignored for vtexft

	* src/vte.c:
	* src/vtedraw.c (_vte_draw_requires_clear):
	* src/vtedraw.h:
	* src/vteft2.c (_vte_ft2_set_background_image):
	* src/vtegl.c (_vte_gl_create), (_vte_gl_set_background_image):
	* src/vtepango.c (_vte_pango_set_background_image):
	* src/vtepangox.c (_vte_pango_x_set_background_image):
	* src/vtexft.c (_vte_xft_set_background_color),
	(_vte_xft_set_background_image):
		Flood fill the backing pixmap if we need to change it's
		opacity as well.

Comment 3 Chris Wilson 2007-03-17 18:03:52 UTC
*** Bug 419428 has been marked as a duplicate of this bug. ***