GNOME Bugzilla – Bug 418015
downloads section does not work with epiphany
Last modified: 2007-05-01 00:15:15 UTC
Hi, It's cool to have a downloads section in the library menu, but does it have to work only on Firefox? I'm an Epiphany user, and I would like to be able to make use of that download section or get rid of it altogether.
Where does epiphany store it's download info? It doesn't use Mozilla's standard downloads.rdf mechanism?
Not sure what info you want, but Epiphany doesn't store downloads after they are finished.
Created attachment 84754 [details] [review] Support monitoring of Epiphany's Download Directory We can get Epiphany's download location from the gconf key /apps/epiphany/directories/downloads_folder Attached is a patch which adds support to DownloadsSource for monitoring Epiphany's download directory. I'm not sure if this is the best way to implement monitoring. Feedback welcomed.
This looks pretty good tony. I think using a GConfBridge with "/apps/epiphany/directories/" set as the prefix would clean up this code a lot though.
Created attachment 84760 [details] [review] Simplify code with GConfBridge Simplified patch with GConfBridge. I didn't realise GConfBridge could be used this way. Shall I do the same to how ItemIconView gets Nautilus' click policy preference from /apps/nautilus/preferences/?
Created attachment 84874 [details] [review] Handle if Epiphany is not installed I've updated the patch to handle the case where the gconf key is not available because Epiphany is not installed.
Created attachment 86495 [details] [review] Fix crash because of incorrect return value from get_enabled()
Tony: I took your patch and altered it to use a separate EpiphanyDownloadsSource, as well as splitting out Mozilla downloads in a similar way. I just committed this to SVN. Please check to make sure I haven't broken anything. Thanks for this awesome patch!