After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 417652 - Scrolling bug exposed by nvi
Scrolling bug exposed by nvi
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.15.x
Other Linux
: Normal critical
: ---
Assigned To: VTE Maintainers
VTE Maintainers
: 421696 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-03-12 21:56 UTC by Chris Wilson
Modified: 2007-03-22 23:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ensure the cursor when updating insert_delta [e.g. after a scroll] (3.73 KB, patch)
2007-03-12 21:57 UTC, Chris Wilson 		none Details | Review
Ensure the row when updating the insert delta (400 bytes, patch)
2007-03-13 21:59 UTC, Chris Wilson 		none Details | Review

Description Chris Wilson 2007-03-12 21:56:17 UTC 
This was reported in Launchpad: https://bugs.launchpad.net/ubuntu/+source/vte/+bug/91017

nvi does not use a restricted scrolling region but instead jumps to the last line, scrolls down, jumps back to the penultimate line and insteads the new text.

Due to a little bit of premature optimization, the insert_delta for the scroll event was only updated after the cursor moved up a row and so did not trigger the required scrolling.
Comment 1 Chris Wilson 2007-03-12 21:57:06 UTC 
Created attachment 84461 [details] [review]
Ensure the cursor when updating insert_delta [e.g. after a scroll]
Comment 2 Chris Wilson 2007-03-13 21:59:40 UTC 
Created attachment 84536 [details] [review]
Ensure the row when updating the insert delta

A much simpler patch without the refactoring.
Comment 3 Chris Wilson 2007-03-16 10:12:26 UTC 
r1836: 2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 417652 – Scrolling bug exposed by nvi

	* src/vte.c (vte_terminal_insert_rows), (_vte_terminal_ensure_row),
	(vte_terminal_ensure_cursor), (_vte_terminal_update_insert_delta):
		Ensure the rows before updating the insert delta and refactor
		the common code.
Comment 4 Chris Wilson 2007-03-22 23:32:27 UTC 
*** Bug 421696 has been marked as a duplicate of this bug. ***