After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 417389 - Scrollwheel on path bar
Scrollwheel on path bar
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2007-03-12 09:35 UTC by Wouter Bolsterlee (uws)
Modified: 2008-03-03 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch of the night (5.48 KB, patch)
2007-04-12 00:37 UTC, Carlos Garnacho
none Details | Review
eek, now with a truly input-only window (5.48 KB, patch)
2007-04-12 00:40 UTC, Carlos Garnacho
none Details | Review
Last try for tonight (9.33 KB, patch)
2007-04-12 01:27 UTC, Carlos Garnacho
committed Details | Review

Description Wouter Bolsterlee (uws) 2007-03-12 09:35:55 UTC
Using the scrollwheel on the path bar in the file chooser dialog should make it "click" other buttons.
Comment 1 Carlos Garnacho 2007-04-12 00:37:18 UTC
Created attachment 86211 [details] [review]
patch of the night

I don't think it should activate the buttons, Instead I've made a patch to just scroll, like when you click the arrows, the input only GdkWindow is in case you scroll in an area not covered by any button.
Comment 2 Carlos Garnacho 2007-04-12 00:40:36 UTC
Created attachment 86212 [details] [review]
eek, now with a truly input-only window

should go to sleep :)
Comment 3 Carlos Garnacho 2007-04-12 01:27:24 UTC
Created attachment 86215 [details] [review]
Last try for tonight

New patch, doesn't try to resize the GdkWindow if the widget is unrealized, adds some path button edge checking to gtk_path_bar_scroll_[down|up] and removes the first parameter in those 2 functions, it was unused.
Comment 4 Wouter Bolsterlee (uws) 2008-01-17 11:02:13 UTC
Any chance to get this in before 2.14?
Comment 5 Federico Mena Quintero 2008-03-03 21:19:26 UTC
Very clever to put the input-only window under the buttons.  Thanks, Garnacho, I just committed this to trunk and gtk-2-12 :)

2008-03-03  Carlos Garnacho  <carlos@imendio.com>

	Fix http://bugzilla.gnome.org/show_bug.cgi?id=417389 - Make the
	scrollwheel work in GtkPathBar.

	* gtk/gtkpathbar.h (struct _GtkPathBar): New field event_window.

	* gtk/gtkpathbar.c (gtk_path_bar_realize): New function.  Create
	an input-only window, event_window, which we'll use to capture
	scroll events.
	(gtk_path_bar_map): Show the event_window under the rest of the
	windows, so it will be a catch-all for unhandled events.