After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 416891 - location bar button goes out of sync with Ctrl+L
location bar button goes out of sync with Ctrl+L
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Navigation
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: Paweł Paprota
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-10 20:05 UTC by Teppo Turtiainen
Modified: 2009-03-19 15:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
screenshot of the problem (13.13 KB, image/png)
2007-03-10 20:06 UTC, Teppo Turtiainen 		  Details
416891-synchronize-location-button-state.patch (1.36 KB, patch)
2008-04-21 19:47 UTC, Paweł Paprota 		committed Details | Review

Description Teppo Turtiainen 2007-03-10 20:05:25 UTC 
Clicking the location bar button toggles between the button based and the text based location bar, but if I activate the text based location bar by pressing Ctrl+L, the button does not get depressed and clicking it won't bring back the button based location bar. I can only get the button based location bar back by clicking it a second time.

Please see attached screenshot.

Related to bug 314894.
Comment 1 Teppo Turtiainen 2007-03-10 20:06:51 UTC 
Created attachment 84355 [details]
screenshot of the problem

Text based location bar is visible, but the toggle button is not depressed.
Comment 2 Cosimo Cecchi 2008-01-18 20:05:17 UTC 
Confirmed with 2.21.5.
Comment 3 Paweł Paprota 2008-04-21 19:47:12 UTC 
Created attachment 109646 [details] [review]
416891-synchronize-location-button-state.patch

Button state should now be synchronized with the bar mode.

However, note that currently pressing CTRL+L shows the location entry *temporarily*, ie. when the path bar is visible and you press CTRL+L, then change location, you'll still get the path bar = CTRL+L doesn't change NAUTILUS_PREFERENCES_ALWAYS_USE_LOCATION_ENTRY preference.

I'm not sure if that's wanted behavior here, maybe someone could cover the usability angle.
Comment 4 André Klapper 2009-03-15 00:51:12 UTC 
Patch available waiting for review...
Comment 5 Cosimo Cecchi 2009-03-19 15:33:42 UTC 
Committed to trunk, thanks for the patch.

2009-03-19  Cosimo Cecchi  <cosimoc@gnome.org>

	* src/nautilus-navigation-window.c:
	(always_use_location_entry_changed),
	(nautilus_navigation_window_set_bar_mode):
	Always synchronize the location bar button with the pathbar
	mode. Patch by Paweł Paprota (#416891).