GNOME Bugzilla – Bug 416635
Rendering glitch: double draw of line below exposed region
Last modified: 2007-03-16 10:19:13 UTC
Lest I forget, Behdad reported this one as well... Occassionally the prompt may rendered bold after an ls - the occurrence is highly dependent on the speed of the input.
The boldness looks to be a result of rendering again without clearing the background first.
Good eyes, Behdad. It definitely appears to be another double draw issue. The tricky part here was to have multiple neighbouring exposed regions, then a slight OBO in paint_area() caused the first paint_area() to render characters belonging to the second paint_area(). [Allowed through the clip mask, since we only create a single mask covering the entire invalidated area. And it is only showing up now as I introduced a patch to reduce the number of redundant clears.] Yet another patch to split out of the queue...
Created attachment 84458 [details] [review] Correct the redundant overdraw, since we now explicitly expand the regions before paint_area()
Created attachment 84656 [details] [review] Correct the redundant overdraw, since we now explicitly expand the regions before paint_area() The previous patch exposed a bug in the enlargement that should have been taking place in vte_terminal_expand_region()
r1838: 2007-03-16 Chris Wilson <chris@chris-wilson.co.uk> Bug 416635 – Rendering glitch: double draw of line below exposed region * src/vte.c (vte_terminal_expand_region), (vte_terminal_paint_area): Kill a couple of off-by-ones.