GNOME Bugzilla – Bug 416447
huge inefficiency when side pane is initially visible
Last modified: 2007-03-10 16:17:15 UTC
The bug has been opened on https://launchpad.net/bugs/88553 "Binary package hint: evince How to reproduce: Open a small PDF with Evince. Activate the side pane (F9), set it to show the index. Close Evince. Now open a large PDF, e.g. the PostgreSQL documentation (~14MB, ~1700 pages). What happens is: It shows the side pane immediately on startup, showing "Loading..." for ~60s with 100% CPU load. After "Loading..." was replaced by the real index, close the side pane (F9), then close Evince. Reopen the PDF. Now it doesn't take up much CPU and only a second after the window was opened, you can press F9 to view the side pane / index. The ~60s of 100% CPU load are not required, they only occur if the side pane is initially visible. ProblemType: Bug Architecture: i386 Date: Wed Feb 28 00:49:24 2007 DistroRelease: Ubuntu 7.04 ExecutablePath: /usr/bin/evince Package: evince 0.7.2-0ubuntu2 ProcCmdline: evince file:///home/frey/Desktop/postgresql-8.2-A4.pdf ... > Thank you for your bug. Don't use the preview sidebar if you don't want it, that's an user choice. Making the preview requires CPU, it's a low priority task though and doesn't block the PDF rendering so that's not a problem ... Please reconsider your decision to Reject this, as I think it was based on a misunderstanding of what I wrote. I wasn't talking about the preview, I was talking about the index. And depending on how you use the program, the same feature/result uses either ~60s of CPU time or less than 1s. This IMHO clearly shows that the CPU time in the inefficient code path is wasted on something which has no use and is not required to show the index. If you need more information (or want me to try to explain it in a different way, in case you think this might help), let me know. Thanks, Daniel"
Created attachment 84316 [details] [review] Patch The problem is that, although thumbnails page is not shown, we are rendering *all* document thumbnails and then links job is run. It only happens when evince is started with side pane opened. This patch fixes the problem.
The patch works fine, thank you
Yes, looks fine for me, can we commit it?
Committed a slightly modified version of the patch.