Bug 416393 – bonobo-activation-server crashed with SIGSEGV

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 416393 - bonobo-activation-server crashed with SIGSEGV


Summary:	bonobo-activation-server crashed with SIGSEGV


Status:	RESOLVED FIXED

Product:	bonobo
Classification:	Deprecated
Component:	libbonobo
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Gustavo Carneiro
QA Contact:	bonobo qa

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2007-03-09 10:39 UTC by Sebastien Bacher
Modified:	2007-03-23 14:59 UTC

See Also:
GNOME target:	---
GNOME version:	2.17/2.18

Attachments
patch (2.10 KB, patch) 2007-03-09 13:55 UTC, Gustavo Carneiro	accepted-commit_after_freeze	Details \| Review

Description Sebastien Bacher 2007-03-09 10:39:44 UTC

The bug has been opened on https://launchpad.net/ubuntu/+source/libbonobo/+bug/90781

"I updated my Ubuntu 7.04 Herd 4 as suggested by Update Manager. An applet in the Gnome 2.18.92 advised me to restart my computer in order that the security settings beome effective. I closed most of my running applications. I commanded restart. There the crash occurred.

ProblemType: Crash
Architecture: i386
Date: Fri Mar 9 06:36:08 2007
DistroRelease: Ubuntu 7.04
ExecutablePath: /usr/lib/bonobo-activation/bonobo-activation-server
Package: libbonobo2-common 2.17.92-0ubuntu1
PackageArchitecture: i386
ProcCmdline: /usr/lib/bonobo-activation/bonobo-activation-server --ac-activate --ior-output-fd=16"

Debug backtrace for the crash:

+ Trace 117145

#0 od_merge_client_environment
at object-directory-corba.c line 420
#1 impl_Bonobo_ObjectDirectory_activate
at object-directory-corba.c line 480
#2 _ORBIT_skel_small_Bonobo_ObjectDirectory_activate
at Bonobo_ObjectDirectory-common.c line 32
#3 ORBit_c_stub_invoke
at poa.c line 2630
#4 Bonobo_ObjectDirectory_activate
at Bonobo_ObjectDirectory-stubs.c line 49
#5 impl_Bonobo_ActivationContext_activateMatchingFull
at activation-context-corba.c line 597
#6 _ORBIT_skel_small_Bonobo_ActivationContext_activateMatchingFull
at Bonobo_ActivationContext-common.c line 52
#7 ORBit_c_stub_invoke
at poa.c line 2630
#8 Bonobo_ActivationContext_activateMatchingFull
at Bonobo_ActivationContext-stubs.c line 87
#9 od_server_activate_factory
at object-directory-activate.c line 62
#10 impl_Bonobo_ObjectDirectory_activate
at object-directory-corba.c line 510
#11 _ORBIT_skel_small_Bonobo_ObjectDirectory_activate
at Bonobo_ObjectDirectory-common.c line 32
#12 ORBit_c_stub_invoke
at poa.c line 2630
#13 Bonobo_ObjectDirectory_activate
at Bonobo_ObjectDirectory-stubs.c line 49
#14 impl_Bonobo_ActivationContext_activateMatchingFull
at activation-context-corba.c line 597
#15 _ORBIT_skel_small_Bonobo_ActivationContext_activateMatchingFull
at Bonobo_ActivationContext-common.c line 52
#16 ORBit_POAObject_invoke
at poa.c line 1142
#17 ORBit_OAObject_invoke
at orbit-adaptor.c line 338
#18 ORBit_small_invoke_adaptor
at orbit-small.c line 844
#19 ORBit_POAObject_handle_request
at poa.c line 1351
#20 ORBit_POAObject_invoke_incoming_request
at poa.c line 1421
#21 giop_thread_queue_process
at giop.c line 771
#22 giop_request_handler_thread
at giop.c line 481
#23 g_thread_pool_thread_proxy
at gthreadpool.c line 264

Comment 1 Gustavo Carneiro 2007-03-09 11:13:58 UTC

Awesome backtrace.  So it crashes around here:

        /* do the actual merging */
        client_env = ((ClientContext *) g_hash_table_lookup
                      (od->client_contexts, client))->env;

Probably g_hash_table_lookup returns NULL, for some reason, and then ->env dereferences the NULL value and crashes.  I think I should just fix that code to check for NULL.  I mean, once the code freeze is over.

Comment 2 Kjartan Maraas 2007-03-09 13:52:43 UTC

If that's enough to fix the crash I guess we should ask for freeze break permission. Can we reproduce this easily?

Comment 3 Gustavo Carneiro 2007-03-09 13:55:15 UTC

Created attachment 84307 [details] [review]
patch

Comment 4 Gustavo Carneiro 2007-03-09 13:57:33 UTC

Sorry Kjartan, hadn't seen your comment.  I personally don't know how to reproduce.  Unless the reporter knows a easy way to reproduce, I prefer to leave it for GNOME 2.18.1.

Comment 5 Sebastien Bacher 2007-03-09 13:58:33 UTC

There is no dup for the crash, it's likely it doesn't happen often or easy to trigger, I think it can be fixed after the freeze

Comment 6 Kjartan Maraas 2007-03-10 17:01:06 UTC

Ok, let's leave it until after 2.18.0 then

Comment 7 Kjartan Maraas 2007-03-23 14:43:04 UTC

Please commit this to both branches.

Comment 8 Gustavo Carneiro 2007-03-23 14:59:43 UTC

Done.