After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 416031 - Arabic encoding not included
Arabic encoding not included
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-03-08 10:41 UTC by Sebastien Bacher
Modified: 2013-09-13 00:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
diff maybe fixing the issue (750 bytes, patch)
2007-03-23 14:46 UTC, Martin Jürgens
none Details | Review
diff fixing the issue (646 bytes, patch)
2007-03-23 15:50 UTC, Martin Jürgens
none Details | Review
diff fixing the issue 2 (704 bytes, patch)
2007-03-23 23:37 UTC, Martin Jürgens
committed Details | Review
Add Windows-1252 support (443 bytes, application/octet-stream)
2007-06-08 10:22 UTC, Martin Jürgens
  Details
add windows-125>>6<< support (443 bytes, patch)
2007-06-08 12:59 UTC, Martin Jürgens
none Details | Review

Description Sebastien Bacher 2007-03-08 10:41:51 UTC
The bug has been opened on https://launchpad.net/ubuntu/+source/evolution/+bug/82322

"Binary package hint: evolution

In Evolution, an Arabic encoding is not being included. Thus, it is not possible to read Arabic e-mails which were written with a client that does not use UTF-8.

The encoding that I miss is the Arabic Windows-1252 encoding.
...
http://librarian.launchpad.net/6466788/attachment
mail

See attached file.

When opening with kmail for example, the mail is not displayed correctly, but via View -> Set encoding, I can select Arabic (windows-1256) and it is displayed correctly then.

In Evolution, that encoding entry is missing in View -> Character Encoding."
Comment 1 Martin Jürgens 2007-03-23 14:28:19 UTC
The encoding that I miss is the Arabic Windows-1256 encoding, not the Windows-1252 encoding. Sorry, I mixed up something.
Comment 2 Martin Jürgens 2007-03-23 14:46:28 UTC
Created attachment 85176 [details] [review]
diff maybe fixing the issue

the attached diff *may* fix the issue.

i am currently doing a build.
Comment 3 Martin Jürgens 2007-03-23 15:50:29 UTC
Created attachment 85181 [details] [review]
diff fixing the issue

The windows-xxx entry was not needed, the mail is being decoded correctly when using ISO-8859-6.

I tried it and it works, yay :)
Comment 4 Martin Jürgens 2007-03-23 23:37:10 UTC
Created attachment 85207 [details] [review]
diff fixing the issue 2

Forgot one line in the patch, added now. Would be nice if you could apply it :)
Comment 5 André Klapper 2007-04-03 16:43:16 UTC
seb, this cannot be committed to 2.18.1, as it breaks the string freeze. somebody would have to get approval from the GDP (gnome-i18n@).
Comment 6 Martin Jürgens 2007-04-05 11:11:16 UTC
I would get an approval if you can describe how the process works.
Comment 7 Srinivasa Ragavan 2007-05-19 09:51:28 UTC
Ill commit this for Evolution 2.11.3 release.
Comment 8 Srinivasa Ragavan 2007-06-03 13:16:08 UTC
Committed to head.
Comment 9 Martin Jürgens 2007-06-08 10:22:00 UTC
Created attachment 89594 [details]
Add Windows-1252 support

In the Ubuntu bugtracker, an user is reporting that he still can't view all mails with Arabic encoding (the patch applied adds the functionality to view *some* mails. but not all).

I prepared a patch which adds Windows-1252 support, but the user still has to test it so please do not apply yet.
Comment 10 Jeffrey Stedfast 2007-06-08 12:43:04 UTC
are you sure it's Windows-1252? 1252 is ~Latin1, not Arabic.

http://www.microsoft.com/typography/unicode/1252.htm

perhaps you mean Windows-1256?
Comment 11 Martin Jürgens 2007-06-08 12:58:56 UTC
Thanks, you are right.. I somewhat mixed them up :(
Comment 12 Martin Jürgens 2007-06-08 12:59:51 UTC
Created attachment 89602 [details] [review]
add windows-125>>6<< support