After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 415389 - crash because NPPVpluginKeepLibraryInMemory is broken in gecko
crash because NPPVpluginKeepLibraryInMemory is broken in gecko
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
unspecified
Other All
: Normal critical
: ---
Assigned To: totem-browser-maint
totem-browser-maint
Depends on:
Blocks:
 
 
Reported: 2007-03-06 17:42 UTC by Alexander Sack
Modified: 2007-03-10 12:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use dlopen to make dbus-glib resident and drop NPPVpluginKeepLibraryInMemory setting (1.56 KB, patch)
2007-03-06 17:43 UTC, Alexander Sack 		none Details | Review
with dlclose (1.63 KB, patch)
2007-03-06 22:38 UTC, Alexander Sack 		none Details | Review

Description Alexander Sack 2007-03-06 17:42:33 UTC 
Steps to reproduce:

See http://bugzilla.gnome.org/show_bug.cgi?id=353503


Stack trace:


Other information:
patch to not use NPPVpluginKeepLibraryInMemory is coming
Comment 1 Alexander Sack 2007-03-06 17:43:53 UTC 
Created attachment 84094 [details] [review]
use dlopen to make dbus-glib resident and drop NPPVpluginKeepLibraryInMemory setting
Comment 2 Christian Persch 2007-03-06 17:46:38 UTC 
You should dlclose the handle. Otherwise this looks fine to me.
Comment 3 Alexander Sack 2007-03-06 22:38:05 UTC 
Created attachment 84125 [details] [review]
with dlclose
Comment 4 Christian Persch 2007-03-07 18:27:33 UTC 
Looks fine to me.

Bastien, since this should fix the epiphany topcrash bug 353503, I think we should try to get this into 2.18.0.
Comment 5 Bastien Nocera 2007-03-07 21:53:37 UTC 
I'd rather keep the NPPVpluginKeepLibraryInMemory as well, in case Gecko fixes it...
Comment 6 Christian Persch 2007-03-07 22:05:04 UTC 
(In reply to comment #5)
> I'd rather keep the NPPVpluginKeepLibraryInMemory as well, in case Gecko fixes
> it...

I guess you mean to #if 0 that instead of removing it?

I don't see why we'd need to put it back though. It was only introduced because libdbus-glib cannot be reloaded; and so I'd argue that making that library (and only that library) resident was actually the right thing to do.
Comment 7 Bastien Nocera 2007-03-08 15:07:24 UTC 
Freeze break requested.
Comment 8 André Klapper 2007-03-08 17:23:16 UTC 
i still don't totally get how this will fix bug 353503...
Comment 9 Christian Persch 2007-03-08 18:30:47 UTC 
It will 'fix' it because the bug is triggered by the plugin's native window not being destroyed correctly, when the plugin is 'cached' with NPPVpluginKeepLibraryInMemory. So with this patch, totem won't trigger that bug anymore (but the gecko bug will still exist).
Comment 10 Bastien Nocera 2007-03-08 22:24:15 UTC 
Code freeze break agreed.

Could you please commit Christian?
Comment 11 Bastien Nocera 2007-03-09 11:58:37 UTC 
I had to adapt the patch, as it is against 2.16.x. Committed to trunk and gnome-2-16.

2007-03-09  Bastien Nocera  <hadess@hadess.net>

        * browser-plugin/totemPlugin.cpp:
        * browser-plugin/totemPluginGlue.cpp: Patch from
        Alexander Sack <asac@jwsdot.com> to keep the dbus-glib
        library in memory, to avoid crashes when switching themes
        (Closes: #415389)
Comment 12 André Klapper 2007-03-09 16:31:09 UTC 
what happens to bug 353503 now?
Comment 13 Alexander Sack 2007-03-10 12:44:58 UTC 
the mozilla bug https://bugzilla.mozilla.org/show_bug.cgi?id=359870 will stay open.

For bug 353503 I would suggest to close it (after a while catching late duplicates maybe?) as the crash should be gone with totem update.