After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 415326 - Totem crash in LIRC code
Totem crash in LIRC code
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-03-06 14:52 UTC by Jan Schmidt
Modified: 2007-03-06 16:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
let LIRC allocate and free its own structs. (392 bytes, patch)
2007-03-06 14:52 UTC, Jan Schmidt 		accepted-commit_now Details | Review

Description Jan Schmidt 2007-03-06 14:52:01 UTC 
I have LIRC support built, but no LIRC configured on my system.

When starting up, totem prints:

** Message: Couldn't read lirc config.

When shutting down, it crashes. 

Looking at the code, it also looks like it allocates an 
lirc_config structure and then throws it away because lirc_readconfig allocates its own. The crash seems to be because the config structure totem allocates cannot be later passed to lirc_freeconfig.

Attaching patch for both problems.
Comment 1 Jan Schmidt 2007-03-06 14:52:43 UTC 
Created attachment 84064 [details] [review]
let LIRC allocate and free its own structs.
Comment 2 Bastien Nocera 2007-03-06 15:21:48 UTC 
Looks good.
Comment 3 Jan Schmidt 2007-03-06 16:59:27 UTC 
2007-03-06  Jan Schmidt  <thaytan@mad.scientist.com>

        * src/totem-remote.c: (totem_remote_init):
        Don't allocate a lirc_config structure - LIRC will do that on its own.
        If lirc_readconfig fails, don't pass data to LIRC that it didn't
        create in the first place. (Closes: #415326)