After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 415181 - update for ConsoleKit parameters
update for ConsoleKit parameters
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-06 05:29 UTC by William Jon McCann
Modified: 2007-03-07 19:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (985 bytes, patch)
2007-03-06 05:38 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2007-03-06 05:29:24 UTC
Here is an update for the latest changes to the ConsoleKit parameters.  I'm sorry that I just missed the code freeze - I tried :)
Comment 1 William Jon McCann 2007-03-06 05:38:13 UTC
Created attachment 84037 [details] [review]
patch

This patch changes the attribute names to reflect changes in ConsoleKit that will be released in sync with GNOME 2.18.  The specific changes here are:

 * rename "host-name" to "remote-host-name" to make it more well defined
 * only set "remote-host-name" if the display is not attached (ie. remote)
 * only set the "x11-display-device" instead of "display-device"
 * remove the "session-type" attribute until it is better defined

I guess we need release-team permission.  But I don't expect a problem since these are very safe changes and none of this code will be executed with a stock GNOME system that doesn't include ConsoleKit.

OK with you Brian?
Comment 2 Brian Cameron 2007-03-07 08:06:06 UTC
Looks good to me.  Can you go ahead and get permission?
Comment 3 William Jon McCann 2007-03-07 19:48:37 UTC
Got approval:
http://mail.gnome.org/archives/release-team/2007-March/msg00050.html

Fixed.  Thanks.