After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 414986 - Don't start the async thread for the system clock until needed
Don't start the async thread for the system clock until needed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.10.13
Assigned To: Jan Schmidt
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-05 17:37 UTC by Jan Schmidt
Modified: 2007-03-12 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Defer starting the async clock thread until needed. (4.96 KB, patch)
2007-03-05 17:38 UTC, Jan Schmidt 		none Details | Review
take 2 (3.24 KB, patch)
2007-03-05 17:39 UTC, Jan Schmidt 		accepted-commit_after_freeze Details | Review

Description Jan Schmidt 2007-03-05 17:37:14 UTC 
Most applications never schedule an async clock callback. Accordingly, there's no need to create a new thread for every system clock and sub-class most of the time.

Attaching a patch that defers creating the thread until the first async clock call.
Comment 1 Jan Schmidt 2007-03-05 17:38:29 UTC 
Created attachment 83985 [details] [review]
Defer starting the async clock thread until needed.
Comment 2 Jan Schmidt 2007-03-05 17:39:38 UTC 
Created attachment 83986 [details] [review]
take 2

try again, without extra cruft in the diff.
Comment 3 Jan Schmidt 2007-03-12 15:28:13 UTC 
        * gst/gstsystemclock.c: (gst_system_clock_init),
        (gst_system_clock_start_async), (gst_system_clock_id_wait_async):
        Defer starting the async system clock thread until the first async
        wait is scheduled. Fixes #414986.