After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 414905 - vino-server crashed with SIGSEGV in rfbAuthCleanupClient()
vino-server crashed with SIGSEGV in rfbAuthCleanupClient()
Status: RESOLVED FIXED
Product: vino
Classification: Applications
Component: Server
2.17.x
Other Linux
: Normal critical
: ---
Assigned To: Jonh Wendell
Vino Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-03-05 13:41 UTC by Sebastien Bacher
Modified: 2007-03-05 19:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Proposed patch (5.66 KB, patch)
2007-03-05 17:29 UTC, Jonh Wendell
none Details | Review
Proposed patch, 2nd try (6.18 KB, patch)
2007-03-05 17:57 UTC, Jonh Wendell
none Details | Review

Description Sebastien Bacher 2007-03-05 13:41:11 UTC
That bug has been opened on https://launchpad.net/bugs/89656

"Binary package hint: vino

here is what i think happened; i was testing connection from a remote (local computer) through VNC. at one point, i was connected through the remote computer, and i asked to disconnect it through the VNC applet icon in the GNOME menu. I think that that point i asked twice. two windows asking for confirmation to disconnect the remote computer appeared, i closed one by saying "disconnect".
later, i tried to connect again from that same remote host. i have VNC set up so that it "asks for confirmation" when someone tries to connect. so the window "XX tried to connect through VNC, do you want to allow or refuse?".
I wanted to click "allow" but the window was not responding. at that point i noticed the old window about disconnecting the remote computer in the previous session. i think i tried to close that old window with "cancel", and i think that it's at that point that vino crashed.
...
Package: vino 2.17.92-0ubuntu1
..."

Debug backtrace for the crash:

  • #0 rfbAuthCleanupClient
    at auth.c line 207
  • #0 rfbAuthCleanupClient
    at auth.c line 207
  • #1 rfbCloseClient
    at sockets.c line 329
  • #2 vino_client_disconnect
    at vino-server.c line 1476
  • #3 IA__g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 77
  • #4 IA__g_closure_invoke
    at gclosure.c line 490
  • #5 signal_emit_unlocked_R
    at gsignal.c line 2440
  • #6 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #7 IA__g_signal_emit
    at gsignal.c line 2243
  • #8 IA__gtk_widget_activate
    at gtkwidget.c line 3946
  • #9 IA__gtk_menu_shell_activate_item
    at gtkmenushell.c line 1024

Comment 1 Jonh Wendell 2007-03-05 17:29:07 UTC
Created attachment 83983 [details] [review]
Proposed patch

This patch:
 - Allows only one disconnect confirmation dialog running;
 - Replaces gtk_dialog_run() with gtk_widget_show() on disconnect confirmation dialog, making it not modal, allowing another windows work.
Comment 2 Jonh Wendell 2007-03-05 17:57:37 UTC
Created attachment 83987 [details] [review]
Proposed patch, 2nd try

- Don't crash if the client disconnects while confirmation dialog is running
- Added a gtk_widget_destroy() in finalize()
Comment 3 Jonh Wendell 2007-03-05 19:04:18 UTC
2007-03-05  Jonh Wendell <jwendell@gnome.org>
	* server/vino-status-icon.c:
	  Allows only one disconnect confirmation dialog running, and
          don't use modal window on that dialog, closes #414905.