After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 414657 - Linked headings should be announced as both heading and link
Linked headings should be announced as both heading and link
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.17.x
Other All
: Normal enhancement
: 2.20.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2007-03-04 18:43 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
test case/sample document (1.02 KB, text/html)
2007-05-17 18:50 UTC, Joanmarie Diggs (IRC: joanie)
  Details
proposed patch (4.72 KB, patch)
2007-05-17 18:52 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-03-04 18:43:02 UTC
On the Orca list, Hermann said:

> I would suggest that a link that's also a heading should be announced
> as both, no matter which caret mode and which kind of navigation.
> The announcement should be "heading link" and then the content.

Currently, if a heading is 100% a heading, we speak "heading" after the text.  If it is a link at the beginning followed by a heading, we say "link" after the linked bit and "heading" after the rest.  If the heading is 100% link, however, we just say "link" after the text.  For a sample, please see this test case: http://svn.gnome.org/svn/orca/trunk/test/html/simpleheader.html

Whether or not it says "heading link" and then the content versus content followed by "heading link" might need some additional consideration and discussion.
Comment 1 Willie Walker 2007-03-14 15:01:26 UTC
Right now, we have some logic (Gecko.py:getContainingLink) to handle situations such as when an image is contained inside a link.  

I wonder if we also need a similar method to get the containing object for a link.  Or, more generally, should we have logic in speechgenerator.py and braillegenerator.py that detects something really is of multiple roles and present those multiple roles?

We have speechgenerator.py._getSpeechForObjectRole which is inconsistently used (we generally call rolenames.getSpeechForRolename instead).  But, there might be opportunity to modify this method to determine compound role names.  We'd probably also need some new stuff in braillegenerator.py to do the same thing for braille.
Comment 2 Joanmarie Diggs (IRC: joanie) 2007-05-13 15:13:17 UTC
Mike, I didn't see where compound roles such as this are addressed in the spec.  What should we speak and braille in the following cases:

1. The entire item is both heading and link, for instance a heading 
   level 2 which is a link called "Chapter 3"

2. The entire item is a heading with links inside of it, such as:

   a.  "Read Chapter 3" (where it's all a heading level 2 and
       "Chapter 3" is also a link)

   b.  "Chapter 3 is worth reading" (where it's all a heading level
       2 and "Chapter 3" is also a link)

   c.  "You should read Chapter 3 and Chapter 4 because they're good."
       (where it's all a heading level 2 and both "Chapter 3" and
       "Chapter 4" are links)

Thanks!
Comment 3 Mike Pedersen 2007-05-16 16:42:34 UTC
I think the best thing to do here is: 
for the example where the whole link is the heading just speak link followed by heading and level at the end.  For the cases where links are contained in a heading speak link after each piece that is a link and then the heading information at the end.  
Comment 4 Joanmarie Diggs (IRC: joanie) 2007-05-17 18:50:25 UTC
Created attachment 88354 [details]
test case/sample document
Comment 5 Joanmarie Diggs (IRC: joanie) 2007-05-17 18:52:15 UTC
Created attachment 88355 [details] [review]
proposed patch

This patch handles links and other things (e.g. images) that are children of headings both for speech and braille.  MIke please give this a test.  Thanks!
Comment 6 Mike Pedersen 2007-05-17 21:51:51 UTC
So far this patch is looking good but I want to find more sites to test it on before I call it good for sure.
Comment 7 Mike Pedersen 2007-05-17 23:47:04 UTC
I think we're OK to call this one good.
Comment 8 Joanmarie Diggs (IRC: joanie) 2007-05-18 01:25:55 UTC
Thanks Mike.

Will: Please review. Thanks!
Comment 9 Joanmarie Diggs (IRC: joanie) 2007-05-18 15:21:59 UTC
Patch committed.  Changing status to pending.
Comment 10 Willie Walker 2007-05-21 17:59:47 UTC
(In reply to comment #9)
> Patch committed.  Changing status to pending.

Just to follow up - Joanie and I went over this off line.  So there really *was* a review.  :-)
Comment 11 Joanmarie Diggs (IRC: joanie) 2007-05-22 15:38:41 UTC
Okay for me to close this one?
Comment 12 Mike Pedersen 2007-05-22 16:52:09 UTC
Sounds good
Comment 13 Joanmarie Diggs (IRC: joanie) 2007-05-22 16:59:36 UTC
Thanks!  Closing as FIXED.