After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 414496 - [id3demux, id3v2mux] Add support for GST_TAG_MUSICBRAINZ_SORTNAME (TSOP) tag
[id3demux, id3v2mux] Add support for GST_TAG_MUSICBRAINZ_SORTNAME (TSOP) tag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.13
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks: 410681
 
 
Reported: 2007-03-04 08:20 UTC by Alex Lancaster
Modified: 2007-03-12 15:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support in gst-plugins-base (535 bytes, patch)
2007-03-04 08:24 UTC, Alex Lancaster 		accepted-commit_after_freeze Details | Review
id3v2mux support (861 bytes, patch)
2007-03-04 08:27 UTC, Alex Lancaster 		accepted-commit_after_freeze Details | Review

Description Alex Lancaster 2007-03-04 08:20:40 UTC 
The GST_TAG_MUSICBRAINZ_SORTNAME maps the TSOP id3v2.4 tag "Performer sort order".  

Here are two patches to add read support in gst-plugins-base and write support gst-plugins-good.
Comment 1 Alex Lancaster 2007-03-04 08:24:19 UTC 
Created attachment 83871 [details] [review]
Support in gst-plugins-base
Comment 2 Alex Lancaster 2007-03-04 08:27:10 UTC 
Created attachment 83872 [details] [review]
id3v2mux support
Comment 3 Wim Taymans 2007-03-09 16:54:21 UTC 
        * gst-libs/gst/tag/gstid3tag.c:
        Add read support for GST_TAG_MUSICBRAINZ_SORTNAME (TSOP) tag.
        Fixes #414496.

        * ext/taglib/gstid3v2mux.cc:
        Add write support for GST_TAG_MUSICBRAINZ_SORTNAME (TSOP) tag.
        Fixes #414496.
Comment 4 Alex Lancaster 2007-03-10 13:18:08 UTC 
Thanks for committing my patch, works fine.

(PS. I know it's only a two-line patch, but isn't it normal custom to note the patch contributor by a "Patch by: " in the ChangeLog?)
Comment 5 Jan Schmidt 2007-03-12 15:50:41 UTC 
Yep, sure is. Added in both commits on Wtay's behalf, since he's currently off in Brazil:

Patch by: Alex Lancaster <alexl at ...>