GNOME Bugzilla – Bug 413942
[wavparse] undetected dts-in-wav
Last modified: 2010-06-11 20:25:32 UTC
+++ This bug was initially created as a clone of Bug #400555 +++ +++ This bug was initially created as a clone of Bug #398196 +++ DTS sample files: http://www.sr.se/cgi-bin/mall/index.asp?programid=2445
for these last files we need to scan more of the wav data because the sync word is not at the beginning of the data.
Yeah, I have a patch for this, but haven't committed it yet since I was pondering moving the typefinding for this to gst-plugins-base.
Do it!
Tim, any news on this?
Ping? :)
Created attachment 156941 [details] [review] DTS typefind function patch (gst-plugins-base) I found this old bug while preparing the DTS typefind function patch. This patch doesn't recognize syncwords in the middle of data. But improving it is trivial. So IIUC wavparse doesn't need the DTS specific code, if the DTS typefind function is properly implemented?
(In reply to comment #6) > Created an attachment (id=156941) [details] [review] > DTS typefind function patch (gst-plugins-base) > > I found this old bug while preparing the DTS typefind function patch. > > This patch doesn't recognize syncwords in the middle of data. But improving it > is trivial. Hi, thanks for the patch and sorry we didn't get to it sooner. I implemented something a bit more elaborate so we can typefind this with more confidence. This should fix the wavparse part (of course we now run all typefinders on the first buffer, which isn't ideal, but shouldn't be too bad given that buffers are quite small and usually the typefinders have already been inited and used to typefind the .wav file in the first place). commit 754f3a315ba37a523cbe114614cb32d666c02abe Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Fri Jun 11 20:50:23 2010 +0100 wavparse: use typefind functions to check if PCM data contains dts stream Use new dts audio typefinder from -base to check if the PCM data contains a dts stream. This way we recognise more varieties more reliably and also detect the dts stream if there isn't a frame sync right at the start of the data. Fixes #413942. commit 12ec2c3d6d3f150e01a08c7455c22b33357d642d Author: Tim-Philipp Müller <tim.muller@collabora.co.uk> Date: Fri Jun 11 20:47:22 2010 +0100 wavparse: set buffer offsets before using the buffer for the first time gst_type_find_helper_for_buffer() will need the correct offset set on the buffer (ie. 0) and not the byte offset we started pulling the data from.