After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 413211 - eog crashed with SIGSEGV in eog_image_load()
eog crashed with SIGSEGV in eog_image_load()
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
2.17.x
Other Linux
: Normal critical
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-28 20:45 UTC by Sebastien Bacher
Modified: 2007-06-24 17:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Ensure an error message is always generated (2.31 KB, patch)
2007-03-06 12:03 UTC, Chris Wilson 		none Details | Review

Description Sebastien Bacher 2007-02-28 20:45:26 UTC 
That bug has been opened on https://launchpad.net/bugs/88710

"Binary package hint: eog

Program crash when viewing photos
...
Package: eog 2.17.92-0ubuntu1
..."

Debug backtrace for the crash:

+ Trace 114728

Thread 1 (process 12703)

  • #0 eog_image_load
    at eog-image.c line 905
  • #1 job_image_load_do
    at eog-full-screen.c line 688
  • #2 eog_job_call_action
    at eog-job.c line 385
  • #3 thread_start_func
    at eog-job-manager.c line 97
  • #4 g_thread_create_proxy
    at gthread.c line 591
  • #5 start_thread
    from /lib/tls/i686/cmov/libpthread.so.0
  • #6 clone
    from /lib/tls/i686/cmov/libc.so.6 

(gdb) p *error
$1 = (GError *) 0x0
Comment 1 Christian Kirbach 2007-02-28 21:13:25 UTC 
good trace with symbols
Comment 2 Chris Wilson 2007-03-06 12:03:30 UTC 
Created attachment 84053 [details] [review]
Ensure an error message is always generated

I did a quick&coarse review of the error handling within eog-image, and it does appear that there are a few paths where image loading could fail without setting an error.
Comment 3 Lucas Rocha 2007-06-24 16:55:41 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

2007-06-24  Lucas Rocha  <lucasr@gnome.org>

        * shell/eog-image.c (eog_image_apply_transformations,
        eog_image_real_load): make sure the error is set in all cases when the
        image loading fails. Patch by Chris Wilson <chris@chris-wilson.co.uk>.
        Fixes bug #413211.
Comment 4 Lucas Rocha 2007-06-24 16:56:35 UTC 
Wait, I completely forgot this patch breaks the string freeze. Reverting first.
Comment 5 Lucas Rocha 2007-06-24 17:33:24 UTC 
As it's not possible to fix this properly in stable branch, I only added the applicable bits of your patch in trunk.

2007-06-24  Lucas Rocha  <lucasr@gnome.org>

        * src/eog-image.c (eog_image_apply_transformations,
        eog_image_real_load): improved error handling on image loading so that
        it catches all failure cases. Fixes bug #413211 (Chris Wilson)