GNOME Bugzilla – Bug 413114
Clock applet preferences does not allow editing of custom format
Last modified: 2007-05-02 12:39:04 UTC
Please describe the problem: The clock preferneces dialog does not allow editing of the custom format after the dialog has been closed once. Steps to reproduce: 1. Set a custom format in apps/panel/applets/applet_?/prefs/custom_format and set format to custom. 2. Right click the clock and select preferences. 3. Everything displays normally. Close preferences. 4. Open preferences again. Clock type is now blank and no custom format field is shown. Actual results: Expected results: Does this happen every time? Yes Other information: Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/gnome-panel/+bug/87346
I also experienced this issue using Fedora Core 6 and Gnome 2.6.13. It would be nice if the option for custom was always in the list of clock types. I only see 12, 24, Unix, or Internet in the list of options. Custom should be in the list, and when it is selected the custom format field should be enabled. Also the applet help should include some documentation about the formats that are accepted by strftime.
Created attachment 87351 [details] [review] Make custom format edit box appear correctly. The problem is that cd->custom_format_shown is not set to FALSE before the call to update_properties_for_format each time the Preferences dialogue is created. Patch attached. Paul: looking at the source code it appears that the intended behaviour is that the custom format fields only appear when either the format is set to custom or the custom_format string is non-empty, set via some other means. Whether or not 'custom' should appear as a choice by default is another issue.
2007-05-02 Vincent Untz <vuntz@gnome.org> * clock.c: (display_properties_dialog): reset custom_format_shown to FALSE. Patch by Jamie Fox <launchpad@jamiefox.me.uk> * clock.schemas.in: add a reference to the strftime manual Fix bug #413114 Jamie is also right about the fact that Custom is only visible when the user already played with it in gconf. This won't change.