After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 412608 - [avidemux] flow return aggregation can ignore errors
[avidemux] flow return aggregation can ignore errors
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-27 12:32 UTC by Mark Nauwelaerts
Modified: 2007-03-07 11:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Possible patch (2.07 KB, patch)
2007-02-27 12:35 UTC, Mark Nauwelaerts 		none Details | Review

Description Mark Nauwelaerts 2007-02-27 12:32:36 UTC 
Currently, gst_avi_demux_aggregated_flow returns GST_FLOW_OK upon the first stream it finds with success flow return.  As such, if a second stream is "in trouble", but the first is not, this would go by undetected.
Comment 1 Mark Nauwelaerts 2007-02-27 12:35:19 UTC 
Created attachment 83456 [details] [review]
Possible patch

Fix gst_avi_demux_aggregated_flow by making it (more) attentive to current flow return.
Comment 2 Wim Taymans 2007-02-28 14:39:17 UTC 
Commited this alternative fix that makes it more similar to oggdemux.

        * gst/avi/gstavidemux.c: (gst_avi_demux_combine_flows),
        (gst_avi_demux_process_next_entry), (gst_avi_demux_stream_data),
        (gst_avi_demux_loop), (gst_avi_demux_chain):
        Fix combined flow return. Fixes #412608.