GNOME Bugzilla – Bug 41245
Sidebar initial width hardwired and not reality-checked
Last modified: 2009-10-07 20:25:02 UTC
There are a set of FIXMEs in nautilus_window_constructed about how the sidebar's initial width is chosen. This bug report represents all of them. See also related bug 41244 about the window dimensions being hard-wired. ------- Additional Comments From sullivan@eazel.com 2000-06-06 15:38:09 ---- The sidebar size is also hard-wired a second time in a different way in nautilus-sidebar.c. There's a FIXME there also, which I've given this same bug number. This situation needs to be straightened out somehow. ------- Additional Comments From ramiro@fateware.com 2000-06-14 19:36:23 ---- reassign to ramiro ------- Additional Comments From ramiro@fateware.com 2000-07-05 11:30:18 ---- assigned ------- Additional Comments From eli@eazel.com 2000-10-16 20:01:52 ---- Batch-assigning QA ownership of remaining bugs to eli@eazel.com ------- Additional Comments From ramiro@fateware.com 2001-01-18 01:12:45 ---- I fixed two of the issues described in this bug: "No constant for the default?" - Default no longer needed in this place. "get_enum? why not get_integer? " - Fixed. Whoever fixes this bug in the future needs to look for FIXMES in nautilus-global-preferences.c (where defaults for preferences are installed) as well as nautilus-window.c. ------- Additional Comments From eli@eazel.com 2001-02-09 11:35:08 ---- Duane is now the proud new QA owner of 'Sidebar', and 'Sidebar Panel: (Other)'. ------- Additional Comments From eli@eazel.com 2001-03-26 11:07:23 ---- QA Assigning to self. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2001-09-09 20:33 -------
This is still valid
Confirming then.
The mentioned fixme's are gone from the function mentioned, but still exist in the following files: ./libnautilus-private/nautilus-global-preferences.c:408 ./src/nautilus-window.c:92 ./src/nautilus-window.c:570 ./src/nautilus-window.c:571 It seems this is no longer an issue. Marking as easy-fix.
[kmaraas@localhost nautilus]$ find . -name *.c | xargs grep -i 41245 ./libnautilus-private/nautilus-global-preferences.c: /* FIXME bugzilla.gnome.org 41245: Saved in pixels instead of in %? */ ./src/nautilus-navigation-window.c:/* FIXME bugzilla.gnome.org 41245: hardwired sizes */ ./src/nautilus-navigation-window.c: /* FIXME bugzilla.gnome.org 41245: Saved in pixels instead of in %? */ ./src/nautilus-navigation-window.c: /* FIXME bugzilla.gnome.org 41245: No reality check on the value? */ ./src/nautilus-window.c:/* FIXME bugzilla.gnome.org 41245: hardwired sizes */
Created attachment 71876 [details] [review] removes uneeded fixmes
The FIXMEs are still there after all these years... Why Stephen's patch has not been applyed yet?
Comment on attachment 71876 [details] [review] removes uneeded fixmes No reason for this bug to still be open. Committing and closing.