After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 412404 - Changing font size doesn't work
Changing font size doesn't work
Status: VERIFIED FIXED
Product: tomboy
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
: 323705 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-02-26 20:45 UTC by Wouter Bolsterlee (uws)
Modified: 2008-02-27 01:30 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Reproduced with this type of note. (18.40 KB, image/png)
2007-03-01 19:48 UTC, Boyd Timothy 		  Details
Use the Activated event instead of the Toggled event (1.93 KB, patch)
2007-03-01 21:10 UTC, Boyd Timothy 		committed Details | Review

Description Wouter Bolsterlee (uws) 2007-02-26 20:45:00 UTC 
1. Type "Title"
2. Select "Title"
3. Change the font size to "large"
4. Type "some text" on a new line
5. Select both "Title" and "some text"
6. Change the font size to "normal"

Expected:
7. Font size is set to "normal"

Actual:
7. Font size is not changed at all.
Comment 1 Boyd Timothy 2007-03-01 19:46:09 UTC 
Using the latest from SVN, I am not able to reproduce this one.  Can you try it with latest SVN and attach the ~/.tomboy.log that is generated?
Comment 2 Boyd Timothy 2007-03-01 19:48:55 UTC 
Created attachment 83673 [details]
Reproduced with this type of note.

Scratch the last comment I made.  I added a bunch of extra lines with different font sizes and can now see the problem.
Comment 3 Boyd Timothy 2007-03-01 21:10:46 UTC 
Created attachment 83683 [details] [review]
Use the Activated event instead of the Toggled event

This patch will activate the size selected by the mouse regardless of which one is currently toggled.
Comment 4 Boyd Timothy 2007-03-01 21:13:46 UTC 
Committed to SVN (r1026).
Comment 5 Wouter Bolsterlee (uws) 2007-03-01 23:40:58 UTC 
Great, confirming it's working correctly now. One possible addition though: why not select *none* of the font size items in the menu if the selection contains mixed size content?
Comment 6 Boyd Timothy 2007-03-01 23:47:48 UTC 
(In reply to comment #5)
> Why not select *none* of the font size items in the menu if the selection
> contains mixed size content?

That would be the very best fix, I agree.  I spent half an hour or so trying to do that and it didn't quite work like I wanted, so I left a "FIXME" comment surrounding this patch mentioning that we should eventually do that.

I'm glad we're thinking on the same page.  Thanks Wouter for keeping on top of this!
Comment 7 Boyd Timothy 2007-03-02 21:41:27 UTC 
*** Bug 323705 has been marked as a duplicate of this bug. ***
Comment 8 Boyd Timothy 2008-02-27 01:30:47 UTC 
Modifying default assignee and qa contact to be tomboy-maint@gnome.bugs.