After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 412255 - HIG, i18n and icons issues in current UI
HIG, i18n and icons issues in current UI
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Search Tool
unspecified
Other All
: Normal normal
: ---
Assigned To: Jamie McCracken
Jamie McCracken
Depends on:
Blocks:
 
 
Reported: 2007-02-26 14:33 UTC by Luca Ferretti
Modified: 2007-03-04 04:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The proposed patch (2.97 KB, patch)
2007-02-26 14:34 UTC, Luca Ferretti
none Details | Review
new stock-email icon (32.17 KB, image/png)
2007-03-04 04:44 UTC, Michael Biebl
  Details

Description Luca Ferretti 2007-02-26 14:33:07 UTC
### Issues ###

1. GNOME HIG suggest to not use accelerators in tabs' labels

2. g_strdup_printf ("%s %d..%d of %d ", _("Showing results"), from, to, count); is a really really bad call for i18n point of view - same for "%s %d %s", _("Showing"), count, _("results")

3. Named icons "email", "image" and "document" are not available on gnome-icon-theme and are undefined in Icon Namind Spec

### Solutions ###

1. Remove accelerators from tabs' labels

2a. Use g_strdup_printf (_("Results %d - %d of %d"), from, to, count)

2b. Use g_strdup_printf (ngettext ("%d result", "%d results", count), count);

3. Use "stock_email", "image-x-generic" and "x-office-document" (note: "stock_email is a legacy icon, will have to replace with something suggested by Icon Naming Utils)

### Availability ###

Attached patch. OK to commit?
Comment 1 Luca Ferretti 2007-02-26 14:34:31 UTC
Created attachment 83387 [details] [review]
The proposed patch
Comment 2 Jamie McCracken 2007-03-02 23:02:30 UTC
pls commit - thx
Comment 3 Luca Ferretti 2007-03-03 10:12:13 UTC
Commited. Closing the bug.
Comment 4 Michael Biebl 2007-03-04 04:44:37 UTC
Created attachment 83864 [details]
new stock-email icon
Comment 5 Michael Biebl 2007-03-04 04:45:46 UTC
I think the new "stock_email" icon does not look very good, because it doesn't match the default icon theme.
The old "email" icon was better imho.