GNOME Bugzilla – Bug 412255
HIG, i18n and icons issues in current UI
Last modified: 2007-03-04 04:45:46 UTC
### Issues ### 1. GNOME HIG suggest to not use accelerators in tabs' labels 2. g_strdup_printf ("%s %d..%d of %d ", _("Showing results"), from, to, count); is a really really bad call for i18n point of view - same for "%s %d %s", _("Showing"), count, _("results") 3. Named icons "email", "image" and "document" are not available on gnome-icon-theme and are undefined in Icon Namind Spec ### Solutions ### 1. Remove accelerators from tabs' labels 2a. Use g_strdup_printf (_("Results %d - %d of %d"), from, to, count) 2b. Use g_strdup_printf (ngettext ("%d result", "%d results", count), count); 3. Use "stock_email", "image-x-generic" and "x-office-document" (note: "stock_email is a legacy icon, will have to replace with something suggested by Icon Naming Utils) ### Availability ### Attached patch. OK to commit?
Created attachment 83387 [details] [review] The proposed patch
pls commit - thx
Commited. Closing the bug.
Created attachment 83864 [details] new stock-email icon
I think the new "stock_email" icon does not look very good, because it doesn't match the default icon theme. The old "email" icon was better imho.