After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 411247 - Use xdg-user-dirs to find music directory
Use xdg-user-dirs to find music directory
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 415338 417852 458148 (view as bug list)
Depends on:
Blocks: 424948
 
 
Reported: 2007-02-23 15:30 UTC by William Jon McCann
Modified: 2007-07-25 14:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rb-xdg-user-dirs.patch (34.25 KB, patch)
2007-03-26 20:23 UTC, Bastien Nocera
none Details | Review

Description William Jon McCann 2007-02-23 15:30:30 UTC
Threads here:
http://lists.freedesktop.org/archives/xdg/2007-February/009343.html
http://lists.freedesktop.org/archives/xdg/2007-February/009382.html

At the very least we should use this for the first start dialog.  Or not show the first start dialog if this is available.
Comment 1 Bastien Nocera 2007-03-06 15:48:39 UTC
*** Bug 415338 has been marked as a duplicate of this bug. ***
Comment 2 Bastien Nocera 2007-03-06 15:49:54 UTC
From my dup:
"
Should add the default Music folder to the filechoosers
As well as the currently selected "Music" folder from the prefs.

You can use http://freedesktop.org/wiki/Software_2fxdg_2duser_2ddirs to get the
default Music folder for the user
"
Comment 3 Bastien Nocera 2007-03-13 13:17:07 UTC
*** Bug 417852 has been marked as a duplicate of this bug. ***
Comment 4 Bastien Nocera 2007-03-26 20:23:02 UTC
Created attachment 85343 [details] [review]
rb-xdg-user-dirs.patch

- Remove first time druid
- Check whether the library paths is empty to set a nice default path instead
- Use xdg-user-dirs to give us some nice default library path
- Add the default music directory to the file chooser windows.
Comment 5 James "Doc" Livingston 2007-04-01 07:43:16 UTC
Looks fine to me, and seems to work. I'd be happy to have this in trunk, and it would finally let us get rid of the druid. yay!
Comment 6 Bastien Nocera 2007-04-01 12:49:08 UTC
Ready to commit once the SVN is back online.
Comment 7 Bastien Nocera 2007-04-01 22:56:52 UTC
My mistake, I had an anon checkout of rhythmbox, so couldn't commit...

2007-04-01  Bastien Nocera  <hadess@hadess.net>

        * data/glade/Makefile.am:
        * data/glade/druid.glade:
        * widgets/Makefile.am:
        * widgets/rb-druid.c:
        * widgets/rb-druid.h: Kill the first-time druid

        * shell/rb-shell.c: (rb_shell_constructor),
        * sources/rb-library-source.c: (rb_library_source_constructor),
        (rb_library_source_library_location_cb): Don't run a first time
        druid on startup, and setup automatically a music library directory
        if the list is empty

        * lib/rb-file-helpers.c: (xdg_user_dir_lookup), (rb_music_dir),
        (rb_file_helpers_shutdown):
        * lib/rb-file-helpers.h:
        Add helper function to get the user's music directory using
        xsg-user-dirs

        * sources/rb-podcast-source.c: (impl_get_config_widget):
        * widgets/rb-dialog.c: (rb_file_chooser_new):
        Add the default music directory to the filechooser dialogues

        (Closes: #411247)
Comment 8 Jonathan Matthew 2007-07-25 14:39:39 UTC
*** Bug 458148 has been marked as a duplicate of this bug. ***