After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 411145 - rhythmbox fails to compile with jobs>1
rhythmbox fails to compile with jobs>1
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
0.9.8
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 423771 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-02-23 10:39 UTC by Gilles Dartiguelongue
Modified: 2007-03-28 15:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rhythmbox-0.9.8-multijob-fix.patch (628 bytes, patch)
2007-02-23 10:40 UTC, Gilles Dartiguelongue
committed Details | Review

Description Gilles Dartiguelongue 2007-02-23 10:39:11 UTC
when compiling rhythmbox with -j6 (for example) the compilation fails because librbmetadatasvc.la is not built yet. (I know it's a corner case, but it's useful on slow boxes in distcc farms). Patch to follow.
Comment 1 Gilles Dartiguelongue 2007-02-23 10:40:28 UTC
Created attachment 83163 [details] [review]
rhythmbox-0.9.8-multijob-fix.patch

This changes the makefile.am rules so that the generated Makefile has the proper dependencies to build the targets in order.
Comment 2 Christophe Fergeau 2007-02-23 11:17:27 UTC
Doesn't that break attempts to build rhythmbox with builddir != srcdir ?
Comment 3 Gilles Dartiguelongue 2007-02-23 12:45:35 UTC
not sure. What I know is that the rules was something like this:

librbmetadata.la: deps
    rules

rhythmbox-metadata: $(top_builddir)/metadata/librbmetadata.la ...
    rules

which leads to librbmetadata.la not being built before rhythmbox-metadata if there is enough compiling slots available because make doesn't recognise that $(top_builddir)/metadata/librbmetadata.la==librbmetadata.la.

If an autofoo master would like to comment, I'd be grateful.
Comment 4 Gilles Dartiguelongue 2007-02-23 14:06:35 UTC
strangely enough I found the same fix for the same kind of bug in seahorse.
I think you don't have to add $(top_builddir)/metadata when the dependencie is in the same folder (it's just a guess on what I've seen in other gnome modules)
Comment 5 James "Doc" Livingston 2007-02-25 01:47:39 UTC
This doesn't break building with builddir != srcdir for me, so I've committed the patch to SVN (trunk and stable branch)
Comment 6 Bastien Nocera 2007-03-28 15:58:00 UTC
*** Bug 423771 has been marked as a duplicate of this bug. ***