GNOME Bugzilla – Bug 410498
Banshee forgets iPod transcoding settings
Last modified: 2007-10-06 15:54:21 UTC
Please describe the problem: Banshee reverts the iPod transcoding settings to AAC after I manually change them to MP3. Steps to reproduce: 1. Plug in an iPod 2. Start Banshee 3. Change the transcoding settings from AAC to MP3 4. Go to the library 5. Go back to the transcoding settings 6. ??? 7. Profit! Actual results: iPod transcoding setting has reverted to AAC Expected results: transcoding setting is remembered Does this happen every time? Yes Other information: Bitrate settings for MP3 transcoding seem to stick, but the selected format doesn't.
Created attachment 85389 [details] [review] Remember the active profile in ProfileComboBox.ReloadProfiles Ok so this patch is probably really not the proper way to fix this issue, but hell, it's my first patch. :) Here's the deal: The transcoding settings get loaded from GConf just fine, but calling ReloadProfiles effectively a) resets the setting to AAC and b) overwrites the settings in GConf. This patch does the simplest thing that could possibly work: stores the active profile at the beginning of ReloadProfiles and sets it back in the end.
Oh, lest I forget: the patch is against SVN HEAD :)
Isn't there a risk in this code that we'll set the Active Profile to a profile that doesn't exist? I think the SetActiveProfile method is there to prevent this.
The ActiveProfile setter calls SetActiveProfile(value); so I don't see much of a difference there, except for the possibility that someone might change the ActiveProfile setter in the future. But if you think it's better to make the call explicit, I may just find the energy to change that single line. :-)
Oh my bad, didn't notice that :-). Looks good then, marking accepted for a final (second) review. Great work, thanks!
Committed, Thanks!