GNOME Bugzilla – Bug 410314
Remove author names from plugins that ship with Tomboy, and list official Tomboy website as the website for those plugins
Last modified: 2008-02-26 20:51:12 UTC
For plugins that are maintained in SVN and shipped with Tomboy, no individual author should be listed in the plugin preferences GUI. The "Authors" listing is sufficient for giving developers credit in the GUI. Users should be able to easily distinguish between plugins shipped with Tomboy (and therefore supported by the maintainers) and those that they may have downloaded from another source. It makes sense for third-party plugins to individually identify their author. The attached patch is a first cut at this that shouldn't break any freezes. It replaces developer names with "Tomboy Project" (to avoid having "Unavailable" listed). It also adds the WebSite property for each plugin. I set it to "http://www.beatniksoftware.com/tomboy" since that is what is listed in "About Tomboy". Any input on these details is appreciated. In the next release, we should consider doing more to differentiate between official and third-party plugins in the preferences GUI. For example, instead of saying "Written By: Tomboy Project", that space in the GUI could read "Official Tomboy Plugin" or "Supported Tomboy Plugin" or something.
Created attachment 83019 [details] [review] Proposed patch for replacing author names with "Tomboy Project" for offical plugins First cut at patch.
We've moved Tomboy's website to: http://www.gnome.org/projects/tomboy/ Please update your patch accordingly and also change the about dialog to use the updated website.
Created attachment 83053 [details] [review] Updated patch - updates all website references
On a side note, it would be cool if the website in the plugin preferences GUI was a hyperlink.
This looks good to me. I don't believe this breaks any string changes, although maybe "Tomboy Project" might. If you're concerned about it, ask the release/i18n team before committing it. Otherwise, get this baby in!
Sent a mail to the list. Now that I think about, is it even possible to mark the "Author" string as translatable? I barely even understand the solution created in http://bugzilla.gnome.org/show_bug.cgi?id=387579 for translating the PluginInfoAttribute. If the i18n team says we need to translated it, I have an idea: pass in some sentinel string like "official" for the Author. Then in the constructor of PluginInfoAttribute, it will check and if the Author comes in as "official", it will actually set it to Catalog.GetString("Tomboy Project") or something like that. Thoughts?
You should just be able to add the following line to tomboy/pot-update.in (add as the middle XGETTEXT line): @XGETTEXT@ --keyword='PluginInfo:3@XGETTEXT_PLUGIN_NAME@' "$@" --join-existing --sort-by-file Once you do that, this should add it to the po/tomboy.pot file, which is then translatable. After changing this file, re-run autogen.sh, remove po/tomboy.pot and in the po/ directory, run "make update-po". That *should* be all you need to do. Let me know if you hit problems.
IHMO using a sentinal is more reasonable here to avoid I18N people run amok by trying to translate author names.
Created attachment 83091 [details] [review] Update patch - use sentinel value for author This version of the patch adds a constant PluginInfoAttribute.OFFICIAL_AUTHOR, which our plugins pass in for the author argument. In the PluginInfoAttribute constructor it checks for that value, and then sets the author to Catalog.GetString ("Tomboy Project").