After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 408295 - Remove "detachable toolbar" option from the ui properties capplet
Remove "detachable toolbar" option from the ui properties capplet
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Other Preferences
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-15 16:40 UTC by Bastien Nocera
Modified: 2007-08-07 18:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnomecc-remove-detachable-toolbars.patch (9.54 KB, patch)
2007-02-16 11:21 UTC, Bastien Nocera
rejected Details | Review
gnomecc-remove-detachable-toolbars-2.patch (3.48 KB, patch)
2007-02-19 11:21 UTC, Bastien Nocera
reviewed Details | Review

Description Bastien Nocera 2007-02-15 16:40:22 UTC
The detachable toolbar doesn't work well. Most applications don't use Bonobo, or its toolbar, so they can't be detached anyway. Given that only a few BonoboUI-powered apps are left, and that most bug reports about that option is that it doesn't work for such and such application, I think it should be removed from the UI, and made into a GConf-only setting.

An example bug report:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223007
Comment 1 Bastien Nocera 2007-02-16 11:21:09 UTC
Created attachment 82667 [details] [review]
gnomecc-remove-detachable-toolbars.patch
Comment 2 Jens Granseuer 2007-02-16 17:03:49 UTC
I'm all for removing the option, but if we still "support" the option in GConf, shouldn't the toolbar preview in the capplet also respect it even if it doesn't allow changing it?
Comment 3 Bastien Nocera 2007-02-16 17:19:40 UTC
That's what I told myself after removing all this code.
Comment 4 Bastien Nocera 2007-02-19 11:21:31 UTC
Created attachment 82877 [details] [review]
gnomecc-remove-detachable-toolbars-2.patch
Comment 5 Bastien Nocera 2007-02-19 11:21:53 UTC
That's far less code removed...
Comment 6 Jens Granseuer 2007-02-19 17:33:45 UTC
Hm, according to GConf docs (and the rest of the code), the signal should be "value_changed". Both seem to work, however.

I'm not sure I like the change for loading the glade file, otherwise looks ok to commit after the freeze lifts.
Comment 7 Bastien Nocera 2007-02-19 18:06:35 UTC
(In reply to comment #6)
> Hm, according to GConf docs (and the rest of the code), the signal should be
> "value_changed". Both seem to work, however.

Usually, the signal entry in the function table uses "_", the signal definition uses "-". This can be changed...

> I'm not sure I like the change for loading the glade file, otherwise looks ok
> to commit after the freeze lifts.

I use the glade change to allow me to load the interface without installing it. Works well for its purpose. The proper fix would be to error out properly when the glade file can't be found...
Comment 8 Jens Granseuer 2007-08-07 18:22:44 UTC
The option's gone in the new appearance capplet. Closing.