After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 408122 - Playlist ordering/sorting is stuck
Playlist ordering/sorting is stuck
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
0.11.6
Other All
: Normal normal
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 531047 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-02-15 04:56 UTC by Andrew Conkling
Modified: 2008-07-31 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
user sort patch (708 bytes, patch)
2007-08-23 04:46 UTC, Aaron D Borden
none Details | Review
Playlist dragging re-enabled (887 bytes, patch)
2007-09-14 04:39 UTC, Henrik Stuart
none Details | Review

Description Andrew Conkling 2007-02-15 04:56:26 UTC
Please describe the problem:
When playing items in a playlist, I cannot move them. It used to seem dependent on the sorting of the library (i.e. I could reorder items as long as the library was not explicitly sorted), but that does not seem to be the case in 0.11.6.

The playlist is not explicitly sorted, though you can resort it by clicking a column header.

Steps to reproduce:
1. Add items to a playlist.
2. Drag and drop them to reorder; they will not be changed.

Actual results:
Nothing, the items remain in the order in which they were added.

Expected results:
I would like the items to be moved around.

Does this happen every time?
Lately, yes, it seems to.

Other information:
I used to be able to work around this behavior by restarting Banshee (when I first reported this on the mailing list, 2006-10-12), but that no longer seems to work.
Comment 1 Cezar 2007-03-20 23:31:53 UTC
I can verify this bugs existence.
Comment 2 Andreas Proschofsky 2007-04-27 10:13:31 UTC
Same here, this is really a major problem for lots of users, as this makes playlists more or less useless in its current form
Comment 3 Scott Cederberg 2007-08-02 20:27:57 UTC
Still exists in version 0.12.1.  When I've started Banshee from the command line, I see the following console message when attempting to reorder a playlist:

"(Banshee:6009): Gtk-CRITICAL **: gtk_list_store_move_after: assertion `!GTK_LIST_STORE_IS_SORTED (store)' failed"

Comment 4 Aaron D Borden 2007-08-23 04:44:24 UTC
(In reply to comment #3)
> "(Banshee:6009): Gtk-CRITICAL **: gtk_list_store_move_after: assertion
> `!GTK_LIST_STORE_IS_SORTED (store)' failed"

This error comes because the ListStore is sorted, and you can not drag and drop on a sorted list. Even if you are not sorting on a column, you are sorting by the "default column" which is defined by the default sort function which does nothing. 

Instead of sorting by the default column, banshee should set the ListStore as "unsorted".
Comment 5 Aaron D Borden 2007-08-23 04:46:43 UTC
Created attachment 94168 [details] [review]
user sort patch

Simple patch accomplishes what I described above. Let me know if there's any problems or what you think.
Comment 6 Andrew Conkling 2007-09-02 03:20:54 UTC
(In reply to comment #5)
> Created an attachment (id=94168) [edit]
> user sort patch
> 
> Simple patch accomplishes what I described above. Let me know if there's any
> problems or what you think.

Nice to see a patch for this. I just patched SVN and tried this, but it doesn't seem to work for me. Anything else I can try?
Comment 7 Henrik Stuart 2007-09-14 04:39:12 UTC
Created attachment 95563 [details] [review]
Playlist dragging re-enabled

The patch made by Aaron Borden (http://bugzilla.gnome.org/show_bug.cgi?id=408122#c5) identified the issue nicely, but misses the initial sort state. It's rememdied in the attached patch, which deals with both issue sites.
Comment 8 Andrew Conkling 2007-10-13 03:44:03 UTC
(In reply to comment #7)
> It's rememdied in the attached
> patch, which deals with both issue sites.

Indeed, this works well for me. Can this be committed?
Comment 9 Andrew Conkling 2008-02-01 02:37:48 UTC
Hmm... just retested this on 0.13.2. Seems to be better. I'm closing this, but if anyone else is still experiencing this bug, please feel free to reopen it.
Comment 10 Andrew Conkling 2008-07-31 15:39:09 UTC
*** Bug 531047 has been marked as a duplicate of this bug. ***