GNOME Bugzilla – Bug 407981
Session hangs up when metacity .sm file is missing
Last modified: 2007-04-09 21:05:18 UTC
Metacity registers to the session manager with the --sm-save-file option, pointing to the file containing - among other things - the client ID. When for some reason or another the file is missing, metacity cannot find back its client ID, and the session manager waits for 120 seconds for a registration that never comes. In theory this should never happen, but it is nevertheless regularly hitting users, see for example http://bugs.debian.org/391287 and http://bugs.debian.org/315169. I see two ways to fix this issue: * allow --sm-save-file and --sm-client-id to be set simultaneously, and register to the session manager with both options; * use the client ID as the filename. The latter approach has the advantage to remain compatible with older metacity versions; I'll see if I can cook up something.
Created attachment 82833 [details] [review] Proposed implementation Here is an implementation of the latter approach described.
Created attachment 83187 [details] [review] Proposed implementation There was a typo in the first patch. This one should be better.
This patch looks good to me, but I'm not confident I know enough about session management to be sure enough to check it in. Can someone else take a look and give us a second opinion?
Actually, you already put this in downstream, didn't you, and it's working fine. So I think it'll be okay to put in trunk. Committed.
*** Bug 148305 has been marked as a duplicate of this bug. ***