GNOME Bugzilla – Bug 407453
gtali shows "Roll 2/3" at end of game
Last modified: 2007-05-21 18:29:02 UTC
[ forwarded from http://bugs.debian.org/410452 ] After playing the last move (typically roll 3) and seeing the message about the winner, the display always shows "Roll 2/3". Either 1/3 or 3/3 would make more sense.
I am currently working on this bug.
Created attachment 87689 [details] [review] Track the roll count to display a meaningful label at game end If the delay option is turned on, then we see all rolls (including computer rolls) and the final roll label is just set to 3 / 3. If the delay option is turned off, then we only see the human player rolls so we keep track of the roll count of the last human player to display at the end of the game, instead of showing a roll count modified by a computer player.
I've tested the patch and it works as advertised. There is one small regression though. Playing multiplayer with no computers and delay turned on will also default to 3/3. (not that it makes any sense, but...) Perhaps change if (DoDelay) to if (DoDelay && numberOfComputers > 0) ?
Created attachment 87787 [details] [review] Track the roll count to display a meaningful label at game end Track the roll count to display a meaningful label at game end. Added additional change to handle case where there are no computer players. Thanks Thomas for testing this patch and for the additional suggestion. :)
Thanks for the patch, it has now been committed to SVN: http://svn.gnome.org/viewcvs/gnome-games?view=revision&revision=6310