After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 406739 - Cannot edit audio profiles from sound-juicer pref dialog
Cannot edit audio profiles from sound-juicer pref dialog
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: media profiles
2.17.x
Other Linux
: Normal normal
: 2.18.1
Assigned To: gnome media maintainers
gnome media maintainers
: 404139 427636 434141 436402 438781 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-02-11 16:06 UTC by Sebastien Bacher
Modified: 2007-06-10 10:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
gnome-media-set-modal.patch (3.01 KB, patch)
2007-04-19 09:53 UTC, Bastien Nocera
committed Details | Review

Description Sebastien Bacher 2007-02-11 16:06:29 UTC
That bug has been opened on https://launchpad.net/ubuntu/+source/sound-juicer/+bug/84007

"Binary package hint: sound-juicer

The problem:

1. Open Sound Juicer Preferences and click Edit profiles
2. Choose some profile and click Edit
3. Try to edit it. It is impossible.

The workaround:

4. Find the "Edit GNOME Audio Profiles" in the task bar.
5. Close that window.
6. Go again to the window "Editing profile XXX" and edit the profile. Now you can.

I am using version 2.16.3 in unstable Ubuntu Feisty.
...
This bug is confirmed on my Sony Vaio Laptop with Feisty. Not even editing the profiles is impossible, but also trying to close any of the three open sound-juicer windows afterwards. So the only way that remains is to look for the running sound-juicer process in the console (ps ax | grep sound-juicer) and kill it manually (sudo kill XXXX). Not a very nice solution! But the above mentioned workaround with editing the Gnome audio settings via the console (gnome-audio-profiles-properties) works fine!"
Comment 1 Bastien Nocera 2007-04-18 16:58:25 UTC
Obviously, it would be too easy if you could reproduce the bug in the test application. Currently, it's broken for sound-juicer and rhythmbox, but not gnome-audio-profiles-test.
Comment 2 Bastien Nocera 2007-04-18 17:24:46 UTC
Matthias pointed out that the problem is that the top "Edit" window is modal (for no reason whatsoever, can't find what makes it that way).
Comment 3 Bastien Nocera 2007-04-19 09:53:28 UTC
Created attachment 86625 [details] [review]
gnome-media-set-modal.patch

Fixes the problem for Rhythmbox and sound-juicer
Comment 4 Bastien Nocera 2007-04-19 10:03:27 UTC
Downstream bug at:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230872
Comment 5 Ronald Bultje 2007-04-19 13:36:09 UTC
is there a reason to remove manage_dialog() as part of this patch? Does that break API (it appears to be public)?
Comment 6 Bastien Nocera 2007-04-19 13:42:24 UTC
(In reply to comment #5)
> is there a reason to remove manage_dialog() as part of this patch? Does that
> break API (it appears to be public)?

It's unused and isn't exported anywhere in the headers.
Comment 7 Ronald Bultje 2007-04-19 13:48:26 UTC
Fair enough then. Thanks!
Comment 8 Bastien Nocera 2007-04-19 14:19:37 UTC
2007-04-19  Bastien Nocera  <hadess@hadess.net>

        * profiles/audio-profile-edit.c: (gm_audio_profile_edit_new):
        * profiles/audio-profiles-edit.c: (edit_button_clicked),
        (delete_button_clicked), (gm_audio_profiles_edit_new),
        (gm_audio_profiles_edit_new_profile):
        Make the edit dialogues modal so that they are editable in
        sound-juicer and Rhythmbox, remove an unused and unexported
        function (Closes: #406739)
Comment 9 DrCurl 2007-04-23 15:06:35 UTC
Don't know if it is related to that bug, but once you mark a profile as active in gnome-audio-profiles-properties (for example, mp3), it stays unavailable in soundjuicer or rhythmbox.
Comment 10 Ronald Bultje 2007-04-23 15:14:13 UTC
You need to restart them - there's another bug to make it instant-apply but I'm considering just trashing that work and going with Aaron's work instead.
Comment 11 DrCurl 2007-04-23 15:27:28 UTC
It doesn't work here, even if I log out / log in gnome, the mp3 profile is never available. Whether it is the default mp3 profile or another I made, it doesn't work. The other profiles (ogg, aac, ...), I can enable/disable them without problems :| ??? (all the gstreamer plugins are installed by the way)
Comment 12 Bastien Nocera 2007-04-23 15:37:52 UTC
(In reply to comment #11)
> It doesn't work here, even if I log out / log in gnome, the mp3 profile is
> never available. Whether it is the default mp3 profile or another I made, it
> doesn't work. The other profiles (ogg, aac, ...), I can enable/disable them
> without problems :| ??? (all the gstreamer plugins are installed by the way)

One of the plugins listed in your MP3 profile doesn't exist. Check with gst-inspect-0.10 <name of plugin>. Please don't add any more unrelated entries to this bugzilla.
Comment 13 Ronald Bultje 2007-04-23 15:39:04 UTC
Oh, then you don't have one of the plugins in your pipeline, most likely the lame plugin.
Comment 14 Bastien Nocera 2007-04-29 09:24:32 UTC
*** Bug 434141 has been marked as a duplicate of this bug. ***
Comment 15 Bastien Nocera 2007-05-06 19:07:08 UTC
*** Bug 436402 has been marked as a duplicate of this bug. ***
Comment 16 Irene Huang 2007-05-17 08:05:22 UTC
*** Bug 438781 has been marked as a duplicate of this bug. ***
Comment 17 Bastien Nocera 2007-06-10 00:32:51 UTC
*** Bug 404139 has been marked as a duplicate of this bug. ***
Comment 18 Bastien Nocera 2007-06-10 00:33:12 UTC
*** Bug 427636 has been marked as a duplicate of this bug. ***