After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 405775 - nokia 770 plugin doesn't report supported types
nokia 770 plugin doesn't report supported types
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-08 15:56 UTC by William Jon McCann
Modified: 2007-02-17 05:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (3.02 KB, patch)
2007-02-08 17:34 UTC, William Jon McCann
committed Details | Review
patch for hal-info (5.67 KB, patch)
2007-02-08 17:36 UTC, William Jon McCann
none Details | Review
hal-info (6.61 KB, patch)
2007-02-09 03:22 UTC, William Jon McCann
none Details | Review

Description William Jon McCann 2007-02-08 15:56:57 UTC
So my ogg vorbis files just get copied to it.  However, it doesn't support ogg.

From http://www.nokiausa.com/770/1,7841,feat:1,00.html :
Supported File Formats

    * Audio: AAC, AMR, MP2, MP3, RA (Real Audio), WAV, WMA
    * Image: BMP, GIF, ICO, JPEG, PNG, TIFF, SVG-tiny
    * Video: 3GP, AVI, H.263, MPEG-1, MPEG-4, RV (Real Video)
    * Internet radio playlists; M3U, PLS

Also:
http://www.internettablettalk.com/2005/12/21/nokia-770-supported-audio-and-video-file-formats/


From http://www.nokiausa.com/N800/1,9008,feat:1,00.html :
Supported file formats

    * Audio: AAC, AMR, MP2, MP3, RA (Real Audio), WAV, WMA
    * Image: BMP, GIF, ICO, JPEG, PNG, TIFF, SVG-tiny
    * Video: 3GP, AVI, H.263, MPEG-1, MPEG-4, RV (Real Video)
    * Internet radio playlists: M3U, PLS 

* Media player does not necessarily support all features of a file format or all the variations of the file formats.

Should this be added to an fdi file?
Comment 1 William Jon McCann 2007-02-08 17:34:23 UTC
Created attachment 82168 [details] [review]
patch

In order for subclasses of generic-source to work correctly things should be initialized in the constructor instead of _new().
Comment 2 William Jon McCann 2007-02-08 17:36:46 UTC
Created attachment 82169 [details] [review]
patch for hal-info

Don't have the 770 product id handy...
Comment 3 William Jon McCann 2007-02-09 03:22:24 UTC
Created attachment 82204 [details] [review]
hal-info

Now with 770 id.
Comment 4 James "Doc" Livingston 2007-02-09 09:24:30 UTC
Patch looks fine to me; the HAL bits will obviously need to go to their bugzilla :)
Comment 5 William Jon McCann 2007-02-09 15:14:36 UTC
Cool.  I've committed the patch and sent a message to the hal list.

http://lists.freedesktop.org/archives/hal/2007-February/007223.html
Comment 6 James "Doc" Livingston 2007-02-17 05:13:07 UTC
Marking Fixed since we're done our end, and it will work if HAL reports correctly.