After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 405739 - sysinfo_logo_expose() mis-renders logo
sysinfo_logo_expose() mis-renders logo
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: sysinfo
git master
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
: 418007 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-02-08 14:14 UTC by alp
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Opening a menu (17.40 KB, image/png)
2007-03-05 11:58 UTC, Jonh Wendell
  Details
Bug itself (16.59 KB, image/png)
2007-03-05 12:00 UTC, Jonh Wendell
  Details
simple fix (451 bytes, patch)
2007-08-01 03:47 UTC, Jared Moore
none Details | Review

Description alp 2007-02-08 14:14:35 UTC
Please describe the problem:
The logo is rendered incorrectly when the exposed area does not cover the entire area of the widget.


Steps to reproduce:
This bug will probably only be reproducable when the user is not using an X compositing manager. Turn off xcompmgr/compiz etc. Go to the System tab in System Monitor. Open the menus such as Monitor and Edit and notice that the logo is rendered at an incorrect offset.


Actual results:


Expected results:


Does this happen every time?


Other information:
The Cairo logic in sysinfo_logo_expose() in sysinfo.cpp is flawed:

cairo_translate(cr, event->area.x, event->area.y);

This translates the starting point of the Cairo context to the origin of the exposure event which may be any point within the widget. Thus the entire logo is drawn starting from the point of the exposure event which is incorrect.

There are many examples of rendering a widget properly using Cairo in Gnome and on the Web.
Comment 1 Jonh Wendell 2007-03-05 11:58:40 UTC
Created attachment 83955 [details]
Opening a menu

Confirm this bug, attaching screenshots
Comment 2 Jonh Wendell 2007-03-05 12:00:34 UTC
Created attachment 83956 [details]
Bug itself
Comment 3 Benoît Dejean 2007-03-13 22:36:20 UTC
*** Bug 418007 has been marked as a duplicate of this bug. ***
Comment 4 Christian Gonzalez 2007-03-14 06:24:04 UTC
I can reproduce the bug with compiz enabled as well.
Comment 5 David Corrales 2007-04-03 16:32:02 UTC
I have been to confirm this bug using Ubuntu Feisty.
Comment 6 petrosyan 2007-07-25 01:05:43 UTC
This bug is still present in System Monitor 2.19.5
Comment 7 Jared Moore 2007-08-01 03:47:21 UTC
Created attachment 92834 [details] [review]
simple fix


This patch seems to have fixed the problem. However I'm pretty new to GTK, so it might not be completely correct. :)
Comment 8 Jonh Wendell 2007-08-01 15:45:54 UTC
The patch works for me.
Comment 9 Jared Moore 2007-08-09 03:22:57 UTC
Any chance of this getting committed for 2.20?
Comment 10 Benoît Dejean 2007-08-21 18:38:26 UTC
As i never experienced the bug, let's give it a try.
Thanks.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 11 Jared Moore 2007-08-22 02:45:31 UTC
Great, thanks :)