GNOME Bugzilla – Bug 405421
TFT head-up brightness appears in centre of screen, rather than 3/5 down
Last modified: 2007-07-26 12:57:40 UTC
Forwarded from https://launchpad.net/bugs/60902 When the brightness changes, a head-up dialogue appears for a couple of seconds. This is in the centre of the screen and covers up anything currently being worked on: http://www.paul.sladen.org/ubuntu/bugs/volume-brightness-location.png The volume-control equivalent appears 3/4 of the way down the screen which is a much better location and does not get in the way. Ideally, the brightness should be the same.
Sure, agree. Is it exactly 3/4 from the top of the screen? Is it measured to the center of the box or just the top? Thanks.
When I was writing a dbus-controlled Head-Up daemon specially /just/ to display on-screen messages, I tried various placements, the 3/5 of the way down the screen looked better than the 3/4 that the audio daemon was using. I presume that this was probably 3/5 for the centre of the box. Eg. the position was probably: at((screen.width-box.width)*1/2, (screen.height-box.height)*3/5); But /play/ first. If this gets changed in g-p-m, it can easily be changed in whatever displays the volume and other status.
Cool cheers. Could you knock up a patch please, as I'm currently unable to test this. If you are busy I can do it in a few weeks time, but it will miss 2-18. Richard.
Created attachment 91804 [details] [review] patch to fix wrong feedback widget position I took care of this bug and wrote a patch that implements for the gpm-feedback-widget the same behaviour of the volume widget. Now they look the same in size and they should appear exactly in the same place.
Cosimo, please commit. Many thanks.
How can I commit it myself?
2007-07-26 Richard Hughes <richard@hughsie.com> * data/gpm-feedback-widget.glade: * src/gpm-feedback-widget.c: (gpm_feedback_show), (gpm_feedback_display_value): Apply a patch from Cosimo Cecchi <anarki@lilik.it> to fix the position and the style of the brightness widget. Fixes #405421