After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 405267 - banshee should stop playing before trying to eject ipod
banshee should stop playing before trying to eject ipod
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - iPod
0.11.6
Other All
: Normal minor
: 2.x
Assigned To: Aaron Bockover
Aaron Bockover
Depends on:
Blocks:
 
 
Reported: 2007-02-07 08:26 UTC by Nico Laum
Modified: 2010-02-04 04:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch to stop playing songs from devices when ejecting them (1.07 KB, patch)
2007-03-12 10:50 UTC, Scott Peterson 		none Details | Review

Description Nico Laum 2007-02-07 08:26:52 UTC 
This should only happen if banshee is playing from ipod at this time. The result is the user will not get an error about ejecting the ipod because it is busy.

Other information:
Comment 1 Josiah Ritchie - flickerfly 2007-02-07 17:31:29 UTC 
Should we assume that you mean it should stop playing only if it is playing something on the iPod? Also, do you want the the iPod to stop playing or put up an error message that you should stop play or both?

Currently on Mass Storage DAPs, the user get a message that they need to start playing a song not on the device.
Comment 2 Nico Laum 2007-02-08 08:40:48 UTC 
(In reply to comment #1)
> Should we assume that you mean it should stop playing only if it is playing
> something on the iPod? Also, do you want the the iPod to stop playing or put up
> an error message that you should stop play or both?
> 
> Currently on Mass Storage DAPs, the user get a message that they need to start
> playing a song not on the device.
> 

Of course, only if it's playing something on the iPod. Banshee should not show an error message. That would be no real improvement.

I think the best way to handle this is just stop playing and eject the iPod and in my opinion this should also be done for Mass Storage DAPs.
Comment 3 Scott Peterson 2007-03-12 10:50:10 UTC 
Created attachment 84421 [details] [review]
a patch to stop playing songs from devices when ejecting them

There seems to be some necessary kludginess in this process: see the patch.
Comment 4 Josiah Ritchie - flickerfly 2007-08-18 18:47:44 UTC 
Is this patch still usable?
Comment 5 Aaron Bockover 2007-10-10 20:26:29 UTC 
A variation this patch is now committed in the stable branch.

http://svn.gnome.org/viewvc/banshee/tags/banshee/banshee-pre-ng-merge/src/Core/Banshee.Base/Dap/Dap.cs?r1=2542&r2=2541&pathrev=2542