GNOME Bugzilla – Bug 405126
POTFILES.in and POTFILES.skip outdated
Last modified: 2007-03-23 21:45:54 UTC
Seems two files should be removed in POTFILES.in and two in POTFILES.skip, because they are no more. Patch is following.
Created attachment 82042 [details] [review] Remove two files in potfiles.in/skip
I'm confused by this patch. The two files listed in POTFILES.in are still in the source directory. ve-nongnome is linked into libvicious.a and glade-helper.c is linked into libviciousui. I don't think GDM uses libviciousui anymore, but is there any harm in listing it for translation changes. These files probably don't ever change anymore, translation or otherwise. I added the two files to POTFILES.skip (config/ssh.desktop .in and gui/gdmsetup.desktop.in) because "make distcheck" was complaining that these files were missing from POTFILES.in/POTFILES.skip. Note these files are generated from ssh.desktop.in.in and gdmsetup.desktop.in.in so they would contain no new strings that aren't already in the .in.in files. Are you able to get "make distcheck" to work okay without needing these two files in POTFILES.skip? Please advise what to do here.
I don't see the vicious-extensions dir in http://svn.gnome.org/viewcvs/gdm2/trunk/ While reading autogen.sh, I see that you ask for checking out the vicious-extensions module (BTW you should replace cvs by svn). So I suppose you should use something like svn:externals so as checkout of gdm2 does automatically get these required files. But I'm no expert in this matter :-/ Concerning the desktop.in files, I cannot answer you right now. CC to Danilo for this.
Yes, the vicious-extensions issue is a known issue. This directory should be a subdirectory of the gdm2 directory, but it is also a separate GNOME module. Refer to bug #394163. http://bugzilla.gnome.org/show_bug.cgi?id=394163 If you (or someone) could help by adding a svn:externals so gdm2 automatically gets these files, I'd be much grateful. This would fix the above bug. I just committed a patch to change references in autogen.sh to refer to SVN instead of CVS.
I'm closing the bug, because the problem with vicious-extensions has been resolved, and the files in POTFILES.skip are correct. Last version of intltool-update shouldn't complain any more about them.