GNOME Bugzilla – Bug 404875
Radio should allow to rename radio groups
Last modified: 2008-08-21 19:46:45 UTC
... rather than you have to rename every group entry of songs in a group. Other information:
Shouldn't be too hard to add.
I have been working on code for this and I have a couple of questions. 1) How do you want to handle the renaming from an interface perspective? Do you want to somehow utilize the StationEditor window? or create a separate dialog for the renaming of the group? 2) You are setting the the Group Name (parent) in the Radio Tree iter, to CanEdit == false assuming this makes sense), and I can not seem to find the code that is doing this. I need to find a way to make that as CanEdit == true so that I can place the "Rename Group" menu option on there instead of one of the stations that element is parenting. Besides those two elements, I have code that mostly handles the renaming. I just need to add a few last minute details like making sure I put the xspf in the proper place and with the correct name and refreshing the interface.
Well since no one answered me, I went ahead and created a new dialog. I have attached the diff and new dialog. I'm still kind of new to programming outside of my own little world and I'm sure that this patch will be found to have issues. So with that in mind, let me know what needs fixing and I'll do my best :-)
Created attachment 89037 [details] [review] Radio Group Rename Patch This is a version 1 of the patch. It works and does not appear to crash the program.
Created attachment 89038 [details] Group Name Editor Dialog This is the Dialog that I made for handling the renaming of the group. I tried to keep it in line with what was in the StationEditor.cs file.
Created attachment 89061 [details] New Patch & New Files - Fixes Broken make My old patch did not include the gtk-gui/ folder that Stetic in Monodevelop makes when you design a window/dialog. This compressed tar has the files, as well as an updated Makefile for the Banshee.Plugins.Radio plugin. Simply untar/bzip this into src/Plugins/Banshe.Plugins.Radio, apply the included patch, and compile. In the words of several of my co-workers "It works on my box"
Created attachment 90181 [details] Updated & Working I just did a build from subversion and noticed some breakage in the previously attached tar.bz2 file. This new one contains the latest .diff and worked fine. Sorry, I guess I really should have my act together before posting files...
Created attachment 90182 [details] [review] Actual Diff This is the actual diff file that is included in the tar.bz2 file. However, these changes will not compile correctly without the files from the tar.bz2 file. I'm uploading this in case someone wants to look at the code changed without worrying about the GTK Dialog I created.
This still needs to be approved and applied, if it's ready
In banshee 1.2, "radio groups" don't exist anymore. You can create playlists of radio stations and rename them. So I'm marking this as fixed.