After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 404569 - [filesrc] Unexpected end of file
[filesrc] Unexpected end of file
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.12
Assigned To: Sebastian Dröge (slomo)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-05 12:29 UTC by Michal Benes
Modified: 2007-02-05 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix eos for nonseekable regular files (782 bytes, patch)
2007-02-05 12:32 UTC, Michal Benes 		committed Details | Review

Description Michal Benes 2007-02-05 12:29:18 UTC 
There is a bug in filesrc resulting in "Unexpected end of file" for nonseekable regular files. The problem is that we do not have total length for nonseekable files. (See patch)
Comment 1 Michal Benes 2007-02-05 12:32:08 UTC 
Created attachment 81922 [details] [review]
Fix eos for nonseekable regular files

One example of nonseekable regular file is a file mounted over nfs
Comment 2 Michal Benes 2007-02-05 12:44:31 UTC 
(In reply to comment #1)
> Created an attachment (id=81922) [edit]
> Fix eos for nonseekable regular files

Note that src->seekable is stronger condition that src->is_regular, this flag is not set for non-regular files.
Comment 3 Sebastian Dröge (slomo) 2007-02-05 12:44:55 UTC 
Thanks, looks good. I'll commit it later.
Comment 4 Sebastian Dröge (slomo) 2007-02-05 13:16:42 UTC 
Ok, committed:

2007-02-05  Sebastian Dröge  <slomo@circular-chaos.org>

        Patch by: Michal Benes <michal dot benes at itonis dot tv>

        * plugins/elements/gstfilesrc.c: (gst_file_src_create_read):
        Correctly generate EOS for non-seekable files. We don't have a total
        length for them and would get an unexpected end of file if we only
        special-cased for regular files. (Fixes: #404569)