After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 404554 - Remember unmaximised size
Remember unmaximised size
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: glines
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-05 11:30 UTC by Sven Arvidsson
Modified: 2007-04-29 08:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
fix (5.05 KB, patch)
2007-04-27 14:50 UTC, Christian Persch
none Details | Review

Description Sven Arvidsson 2007-02-05 11:30:12 UTC
This is Debian bug 409382.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=409382

If you close glines when maximised, it will start up maximised. Pressing maximise/unmaximise will now only toggle between the two states. 

It will not change the size of the window, as the unmaximised size of the window now is the same as the size of a maximised window.


This behaviour is a little bit confusing as it's easy to miss that the game can be unmaximised, as in the original bug reported to Debian (see URL above).

This isn't entirely consistent between GNOME applications, some will remember the unmaximised state, some will not, and others won't start maximised at all.

I filed this for glines as the original report, but I believe many of the games have the same problem.
Comment 1 Christian Persch 2007-04-27 14:50:32 UTC
Created attachment 87146 [details] [review]
fix

This fixes the bug, and also stores maximised/fullscreened state and restores it on startup.
Comment 2 Andreas Røsdal 2007-04-28 11:59:23 UTC
Thanks for the patch, Christian. It has been applied to the current SVN version.

However, several of the other games in gnome-games have the exact same problem, for example Aisleriot. This is something which really should be consistent across all the games, but it is not that visible or critical.
Comment 3 Christian Persch 2007-04-28 13:09:09 UTC
I have fixed that in my tree for aisleriot too. Maybe separate bugs should be filed for each game where this is a problem?
Comment 4 Robert Ancell 2007-04-29 08:16:06 UTC
I've fixed this for glChess (SVN head)