After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 403597 - [API] Add ReplayGain reference level tag
[API] Add ReplayGain reference level tag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal enhancement
: 0.10.12
Assigned To: Tim-Philipp Müller
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-02 14:50 UTC by René Stadler
Modified: 2007-02-12 11:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add ReplayGain reference level tag (1.19 KB, patch)
2007-02-02 14:51 UTC, René Stadler
committed Details | Review
Add vorbis comment mapping for ReplayGain reference level tag (587 bytes, patch)
2007-02-02 14:52 UTC, René Stadler
committed Details | Review

Description René Stadler 2007-02-02 14:50:46 UTC
With the new FLAC, a new tag was invented to store the ReplayGain reference level.  It maps to the vorbis comment field name "REPLAYGAIN_REFERENCE_LOUDNESS".  I propose adding support for this tag alongside the other ReplayGain tags.  The purpose of the tag is to put an end to the ambiguity that is inherent to the relative gain adjustment values.  So in a sense, the invention of this tag comes 6 years too late, but hey!

I'm attaching a patch to add the tag as GST_TAG_REFERENCE_LEVEL.  I oppose taking over the "reference loudness" term used for the comment field name because doing so makes no sense; the ReplayGain proposed standard always uses the term "reference level" to refer to the 89 dB (back then 83 dB) target output level of the reference waveform.  The term "reference loudness" is only used once (in the MATLAB script), where it refers to the result of the RG function (which is meaningless by itself).

Another patch against gst-plugins-base will be attached that adds the new tag to gstvorbistag.c, which should enable support in all formats that use vorbis comments.

As part of another bug, I'll add support for the tag to the element(s) that are part of the replaygain plugin.
Comment 1 René Stadler 2007-02-02 14:51:51 UTC
Created attachment 81764 [details] [review]
Add ReplayGain reference level tag
Comment 2 René Stadler 2007-02-02 14:52:47 UTC
Created attachment 81765 [details] [review]
Add vorbis comment mapping for ReplayGain reference level tag
Comment 3 Tim-Philipp Müller 2007-02-12 11:01:44 UTC
Thanks, committed (added the missing 'Since:' bits to the doc chunk):

 2007-02-09  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: René Stadler <mail at renestadler de>

        * docs/gst/gstreamer-sections.txt:
        * gst/gsttaglist.c: (_gst_tag_initialize):
        * gst/gsttaglist.h:
          API: add GST_TAG_REFERENCE_LEVEL (#403597).

 2007-02-12  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: René Stadler <mail at renestadler de>

       * gst-libs/gst/tag/gstvorbistag.c:
         Add vorbis/FLAC-tag mapping for new GST_TAG_REFERENCE_LEVEL
         (#403597).