After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 403565 - nautilus crashes after ejecting CD ROM disc
nautilus crashes after ejecting CD ROM disc
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
2.17.x
Other All
: Normal critical
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-02 13:08 UTC by padraig.obriain
Modified: 2007-02-02 14:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Proposed patch (2.39 KB, patch)
2007-02-02 13:14 UTC, padraig.obriain
none Details | Review
Proposed patch (500 bytes, patch)
2007-02-02 13:19 UTC, padraig.obriain
none Details | Review

Description padraig.obriain 2007-02-02 13:08:07 UTC
Steps to reproduce:
1. insert a CD ROM disc; icon appears on desktop and file browser window is opened.
2. eject the CD; the CD is ejected and the file browser attempts to display my home directory. A message box stating that nautilus has crashed appears.
3. 


Stack trace:
 % pstack 882
882:    nautilus --no-default-window --sm-client-id default2
-----------------  lwp# 1 / thread# 1  --------------------
 fef58f17 waitid   (0, 5b3, 8045ea0, 3)
 fef4c996 waitpid  (5b3, 8045fac, 0) + 70
 fe37886a libgnomeui_segv_handle (6) + ba
 080b0fea sigfatal_handler (6, 0, 8046070) + 6a
 fef5801f __sighndlr (6, 0, 8046070, 80b0f80) + f
 fef4d62b call_user_handler (6, 0, 8046070) + 2b8
 fef4d7d2 sigacthandler (6, 0, 8046070) + c2
 --- called from signal handler with signal 6 (SIGABRT) ---
 fef58c67 _lwp_kill (1, 6) + 7
 fef122b2 raise    (6) + 22
 feef0eb4 abort    (0, 0, fe5a1e44, fe5f6608, 8046320, 0) + 64
 fe53b1f4 g_logv   (fe5e1a34, 8, fe5e1a0c, 80467ac) + 340
 fe53b21d g_log    (fe5e1a34, 8, fe5e1a0c, fe5e1974, 6b1, fe5e1644) + 25
 fe5c3e29 g_object_ref (0) + b5
 08103efc nautilus_desktop_icon_file_get_link (824bb28) + 20
 080ce2f6 real_update_menus (832c500) + e6
 080dcd7c fm_directory_view_update_menus (832c500) + 5c
 080d2ac1 update_menus_timeout_callback (832c500) + 49
 fe536080 g_timeout_dispatch (869cfd8, 80d2a78, 832c500) + 24
 fe53371d g_main_dispatch (81b3f88) + 1d9
 fe53480d g_main_context_dispatch (81b3f88) + 85
 fe534c2a g_main_context_iterate (81b3f88, 1, 1, 8191770) + 3ce
 fe53522c g_main_loop_run (824a548) + 1b8
 fe75ad36 gtk_main (8046d54, 8046bf0, feffa7c0, 0, 0, 815daec) + b2
 080b1902 main     (4, 8046c34, 8046c48) + 8b6
 080a0b16 _start   (4, 8046dbc, 8046dc5, 8046dd9, 8046de8, 0) + 7a
-----------------  lwp# 15 / thread# 15  --------------------
 fea1e014 mount_unmount_thread(), exit value = 0x00000000
  

Other information:
Comment 1 padraig.obriain 2007-02-02 13:14:20 UTC
Created attachment 81757 [details] [review]
Proposed patch
Comment 2 padraig.obriain 2007-02-02 13:18:38 UTC
Comment on attachment 81757 [details] [review]
Proposed patch

--- /usr/tmp/clean/nautilus-2.17.90/libnautilus-private/nautilus-desktop-icon-fi
le.c    Wed Jan  3 08:52:25 2007
+++ nautilus-2.17.90/libnautilus-private/nautilus-desktop-icon-file.c   Fri Feb
 2 12:00:15 2007
@@ -321,7 +321,10 @@
 NautilusDesktopLink *
 nautilus_desktop_icon_file_get_link (NautilusDesktopIconFile *icon_file)
 {
-       return g_object_ref (icon_file->details->link);
+       if (icon_file->details->link)
+               return g_object_ref (icon_file->details->link);
+       else
+               return NULL;
 }

 static void
Comment 3 padraig.obriain 2007-02-02 13:19:51 UTC
Created attachment 81758 [details] [review]
Proposed patch
Comment 4 Alexander Larsson 2007-02-02 14:04:13 UTC
commited.