GNOME Bugzilla – Bug 403320
make volume overlay themeable
Last modified: 2007-02-05 21:18:18 UTC
Here's a patch to make the new composited volume overlay themeable.
Created attachment 81689 [details] [review] patch This makes the icon and volume bar themeable. If the themed icon cannot be found then it uses the cairo drawn version. Also adds a test program.
Created attachment 81690 [details] screenshot mid level
Created attachment 81691 [details] screenshot max
Created attachment 81692 [details] screenshot muted
I've been getting some feedback on this. People seem to really dislike the red x. One person thought it was a button and wondered what would happen if it was clicked and another thought it indicated an error message. Some people thought it is too colorful. I showed the following to two people and they seemed to like it better: http://jimmac.musichall.cz/stuff/volume-git-mockup-simple.png They like the simplicity of it (one was an OS X user and the other an XP user). If we use the white/simple one then we may want to use no 'waves' instead of a red box to indicate mute.
If we go this route then we probably need to have a nice SVG icon for eject also. I can't seem to find one in the icon theme - anyone know?
You can use media-eject. We can't replace the icon theme icons with straight flat white icons though. Perhaps they can be somewhat simplified, but I think people more or less try to make up excuses to not like some icons. The same icon has been used for years as the mute icon. The fact that it has a red square with an x is nothing new. The fact that it's in a pop-up that's quite a bit larger probably makes it a bit more prominent though. That, and people are used to the OSX thing being all white, so the obvious best solution is to do exactly what they do, in a lot of eyes. Of course, this is not always the case.
I agree that the large icon is sub-optimal, but that's something for theme authors to fix, IMO, not something for us to work around. This patch looks fine by me.
Created attachment 81724 [details] [review] patch * use media-eject icon if available * make sure icon returned is close to requested size * add a border around progress bar * make test app test all modes Seems like gnome-icon-theme doesn't have an SVG icon for media-eject. After I added one from the tango set then things look much better. Rodney, can we add a scalable action icon for media eject? Good to commit?
I thought it had one. Maybe jimmac only did the bitmaps since the scalable isn't really used in any media apps, given that toolbar/button/menu icons are all 24x24 or smaller. Jakub, can you please draw a scalable media-eject icon for git?
Created attachment 81781 [details] [review] patch * also make the overlay background follow the theme background * add a border to the cairo drawn icons (fallback icons) Anyone object to me committing this?
I'll fix up a scalable media-eject in the meantime.
media-eject SVG is in g-i-t trunk.
Thanks Jakub. I've committed this now.
First I thought I don't like the added color but that's not really the problem. But the window feels quite intrusive now. Would it be possible to add some opacity to the icon and the bar? Something like 50%-75% would be nice I think. Right now the icon and the bar feels to much like "part of the desktop" and not really part of this particular pupup.
I just committed a patch to use #defines for the alpha levels. So if you want to try making the icons and bar translucent then set FG_ALPHA to somthing less than 1.0. I really don't know what's preferred. It might be worth staying consistent with the ALT-TAB window from compiz though. And that is translucent for the background and opaque for the foreground.
In compiz it wouldn't make sense to have the tasks displayed transparently... and those elements actually represent "objects". In case of the speaker/open icons, those are not "objects" in the sense that you cannot click on them (see comment #5). This is why a transparency of at least 75% would be nice to have, perhaps even more.
Created attachment 81956 [details] Bug This shows a strange vertical line. I've never seen this in the old version...
That looks like a cairo bug or something. The change I made should not cause that (I changed cairo_paint(foo) to cairo_paint_with_alpha (foo, 1.0).