After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 402925 - Evolution uses weak encryption for SSL/TLS
Evolution uses weak encryption for SSL/TLS
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.10.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: C de-Avillez
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-01-31 18:49 UTC by Fridtjof Busse
Modified: 2013-09-13 00:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
enable high-end ciphersuites on libnss (802 bytes, patch)
2007-07-09 16:20 UTC, C de-Avillez
none Details | Review
corrected indentation - enables high-end ciphersuites (804 bytes, patch)
2007-07-10 16:44 UTC, C de-Avillez
committed Details | Review

Description Fridtjof Busse 2007-01-31 18:49:33 UTC
Please describe the problem:
Evolution uses weak encryption when sending mail via SSL/TLS.
 E.g., the server supports AES 256 bit, but Evolution uses the probably weakest encryption available (no matter if TLS on port 25 or SSL on port 465):
(using TLSv1 with cipher RC4-MD5 (128/128 bits))

I consider this a serious bug, as RC4-MD5 is definitly not a good idea.
Manually connecting via 'openssl s_client' to the server I used for testing shows:
 SSL-Session:
     Protocol : TLSv1
     Cipher : DHE-RSA-AES256-SHA

So it definitly works on the server-side.

Steps to reproduce:
1. Send mail via a TLS/SSL-enabled mailserver
2. Check the used encryption



Actual results:


Expected results:


Does this happen every time?
Yes

Other information:
Comment 1 Sebastien Bacher 2007-01-31 20:03:23 UTC
Ubuntu bug about that: https://launchpad.net/ubuntu/+source/evolution/+bug/82515
Comment 2 Daniel Holbach 2007-02-06 12:31:51 UTC
Tentative patch at: https://launchpad.net/ubuntu/+source/evolution/+bug/82515/comments/6
Comment 3 Fridtjof Busse 2007-02-13 10:45:48 UTC
Any comment on this bug from a developer? 
Judging from the really short patch, the fix seems to be quite simple and would enable AES, which is quite important if there's a company policy regarding encryption...
Even without that, there seems to be no reason for not supporting strong encryption.
Comment 4 C de-Avillez 2007-07-09 16:19:17 UTC
Comments from the Ubuntu bug (https://bugs.launchpad.net/evolution/+bug/82515/comments/5):



it really looks like Evolution is letting the factory defaults for NSS take over -- which means that, although permitted, most of the high-end encryption suites are not enabled.

I am assuming the ubuntu release of Evolution is using libnss (at least this is what is marked). I have not looked at Evolution with OpenSSL.

In camel.c @ camel_init(), Evolution sets up the use of domestic encryption via a call to NSS_SetDomesticPolicy(), but does not set up the (by default) not enabled ciphersuites, which the Mozilla documentation state as required. This would require calls to SSL_CipherPrefSetDefault() globally, or SSL_CipherPrefSet() on each socket. I cannot find any such calls in the code.

So... it looks that Evolution does need a patch in order to allow high-end ciphersuites to be used. It is missing the necessary setup.

c.f. http://www.mozilla.org/projects/security/pki/nss/ref/ssl/sslfnc.html#1214758

Of course, I may be completely wrong, but I do not think so.
Comment 5 C de-Avillez 2007-07-09 16:20:55 UTC
Created attachment 91506 [details] [review]
enable high-end ciphersuites on libnss

tentative patch below. All SSLV2 ciphersuites are enabled by default, so I do not go on calling SSL_CipherPrefSetDefault() on them. For simplicity, we could.

This deals with libnss only.
Comment 6 C de-Avillez 2007-07-10 16:44:56 UTC
Created attachment 91555 [details] [review]
corrected indentation - enables high-end ciphersuites
Comment 7 Srinivasa Ragavan 2007-07-11 06:07:59 UTC
Thanks to Fejj's review :) Please commit to head.
Comment 8 Srinivasa Ragavan 2007-07-28 20:04:12 UTC
Committed.