GNOME Bugzilla – Bug 402797
[Patch] Make it easier to switch back to Preferences menus
Last modified: 2007-02-19 16:46:46 UTC
These two patches (one for gnome-menus and one for gnome-control-center) make the switch from the new control center shell to the old menus. This is done through the following changes: gnome-menus ----------- * Revert the re-arrangements in preferences.menuso the Preferences menu is exactly like the old one. * Add the Administration and the Preferences menu back to settings.menu. * Add NoDisplay=true to Preferences.directory and System-Settings.directory. This makes the menus hidden by default. The trick: though they are hidden, the menus will appear in menu editors (I tested with alacarte) and can be easily enabled. gnome-control-center -------------------- * To preserve the categories in the control center shell, ship an own gnomecc.menu file with them. * Add gnomecc.directory for gnomecc.menu. * Change the shell to use gnomecc.menu. One problem still remains: currently gnome-panel doesn't read in settings.menu anymore. Can you fix that, Vincent (maybe by reverting the change)?
Created attachment 81583 [details] [review] Easier switch to preferences menus (gnome-menus patch)
Created attachment 81584 [details] [review] Easier switch to preferences menus (gnome-control-center patch)
Please don't use hard-coded paths ("/usr/share/...", in both patches). Instead, use an .in file that gets populated with the proper values by configure.
Excuse me, those <LegacyDir> tags shouldn't be there anyway. Please ignore them, they wouldn't be commited.
Created attachment 81664 [details] [review] Easier switch to preferences menus (gnome-menus patch) Removed the slipped-in <LegacyDir>.
Created attachment 81665 [details] [review] Easier switch to preferences menus (gnome-control-center patch) Removed the slipped-in <LegacyDir>.
This change also requires alacarte to make editing settings.menu possible again. CC'ing the maintainers.
I committed the gnome-menus patch.
I'm wondering if all of the .directory files that were added to gnome-menus should be kept there, or if they should be moved to the control center. I've no strong opinion on this...
Created attachment 82018 [details] [review] Easier switch to preferences menus (gnome-control-center patch) Hope I got it right this time :)
Okay, so I'm kind of confused. I'm getting bugs for gimmie running on 2.17.90 that the flattened settings tree loaded from settings.menu contains only gnomecc.desktop. To get a listing of all preferences and system-settings, as settings.menu used to give me, should I load gnomecc.menu if it exists? Or was it a bug that gnomecc.menu wasn't being included in settings.menu for 2.17.90?
(In reply to comment #11) > Okay, so I'm kind of confused. I'm getting bugs for gimmie running on 2.17.90 > that the flattened settings tree loaded from settings.menu contains only > gnomecc.desktop. > > To get a listing of all preferences and system-settings, as settings.menu used > to give me, should I load gnomecc.menu if it exists? Or was it a bug that > gnomecc.menu wasn't being included in settings.menu for 2.17.90? > settings.menu also contains the old menus, but they are hidden by default, so they must be enabled by a menu editor or by changing NoDisplay=true to NoDisplay=false in Preferences.directory and System-Settings.directory.
Okay, so this sucks for gimmie's out-of-box experience. What do you guys suggest for getting the old settings.menu behavior? Trying to load gnomecc.menu? Loading both preferences.menu and system-settings.menu?
(In reply to comment #13) > Okay, so this sucks for gimmie's out-of-box experience. What do you guys > suggest for getting the old settings.menu behavior? Trying to load > gnomecc.menu? Loading both preferences.menu and system-settings.menu? > If the categories should be there, loading gnomecc.menu would be the right thing. If not, the best thing might be an own .menu file (Preferences.directory and System-Settings.directory couldn't be used because they contain the NoDisplay=true definition, so preferences.menu cannot be used if Preferences.directory is hidden).
All patches commited. @Alex: if you still have problems with the current menu situation in gimmie, please open up a new bug.