After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 402756 - Can not open a file whose name is in non-ascii encoding
Can not open a file whose name is in non-ascii encoding
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.16.x
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2007-01-31 09:18 UTC by agc-tester
Modified: 2007-06-07 01:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
screen snapshot (145.82 KB, image/jpeg)
2007-01-31 09:19 UTC, agc-tester 		  Details
Patch for src/actions.c, src/file-utils.c, src/file-utils.h, src/main.c, src/window.c (7.01 KB, patch)
2007-02-16 04:31 UTC, Takao Fujiwara 		none Details | Review
Patch for src/actions.c, src/file-utils.c, src/main.c, src/fr-window.c (5.80 KB, patch)
2007-06-06 14:31 UTC, Takao Fujiwara 		accepted-commit_now Details | Review

Description agc-tester 2007-01-31 09:18:18 UTC 
Please describe the problem:
file-roller fails to open files with non-ascii names.

Steps to reproduce:
1. Open nautils, and double click one .tar.gz file whose name contain non-ascii characters;
2. An error message pop-up:
   can not open the file,this file does not exist;



Actual results:


Expected results:
if the tar.gz file's name doese not contain non-ascii chatacters,double-click the file will open the file successfully.

Does this happen every time?
Yes.

Other information:
The attachment is the error message.
Comment 1 agc-tester 2007-01-31 09:19:24 UTC 
Created attachment 81573 [details]
screen snapshot
Comment 2 Takao Fujiwara 2007-02-16 04:27:05 UTC 
Several bugs are reported on none UTF-8 locales:

How to reproduce:

    Step1: prepared one Archive file with non-ASCII characters name
    Step2:Double click one it 
    
Result:
    One message popup, The file don't exist
    If you start 'Archive manager'app, and then click File->open->'The archive file',
The archive can be opened.
    

How to reproduce:

    Step1: prepare one archive file with non-ASCII characters name
    Step2:Double click on it 
    
Result:
    One message popups: The file doesn't exist
    If you start 'Archive manager'app, and then click File->open->'The archive file',
The archive can be opened.

How to reproduce:
    Step1: Open one Archive file with non-ASCII characters name
    Step2: Click on 'File->save as'
    Step3: Save as frame popup,but the non-ASCII characters name changed to garbage
Result:
    Ahe 'save as 'frame ,the non-ASCII characters name changed to garbage

How to reproduce:
    Step: 
       1.  Click on new create Archive file icon, New create frame popuped
       2.  Input a archive file name with non-ASCII character
       3.  select 'archive type' for 'zip'
     Result : The archive name changed to garbage 

    Step: 
       1.  Click on new create Archive file icon, New create frame popuped
       2.  select 'archive type' for 'zip'
       3.  Input a archive file name with non-ASCII character
       4.  Double click on the new archive file
      Result:A error frame popuped, the new archive file name displaied garbage
     
Result:
    File name displaied garbage


I'm attaching the patch to fix all bugs.
Comment 3 Takao Fujiwara 2007-02-16 04:31:26 UTC 
Created attachment 82654 [details] [review]
Patch for src/actions.c, src/file-utils.c, src/file-utils.h, src/main.c, src/window.c

Attached the patch.
G_OPTION_REMAINING is converted from the locale encoding to UTF-8 so applications need to convert the UTF-8 string to locale string.

Also added get_filename_charset() to check the environment.
Comment 4 Paolo Bacchilega 2007-06-04 16:02:38 UTC 
Takao, can you please do a patch for current svn ?
Comment 5 Takao Fujiwara 2007-06-06 14:31:29 UTC 
Created attachment 89478 [details] [review]
Patch for src/actions.c, src/file-utils.c, src/main.c, src/fr-window.c

I updated the patch for SVN HEAD. Could you review this?
Comment 6 Paolo Bacchilega 2007-06-06 18:48:25 UTC 
the patch looks good, I've committed it to SVN now, thank you.
Comment 7 Takao Fujiwara 2007-06-07 01:10:37 UTC 
Thanks much for the integration.