GNOME Bugzilla – Bug 401263
Image files don't honour ALL_LINGUAS during build.
Last modified: 2007-01-28 17:04:20 UTC
Currently gimp-doc does not use ALL_LINGUAS during images installation and thus installs all images even if ALL_LINGUAS was set only to en. This increases building time if configured with --enable-convert as more pictures require "Converting..." and also this increase disk usage of installed documentation (whole installation occupies 37934036 bytes (42M) and if only images for en and ru installed 20808336 bytes (24M)).
Created attachment 81317 [details] [review] Makefile.am patch. With the feedback gathered on the mailing list and in our bugzilla this patch: * Always install pictures in listed in IMAGE_DIRS (images for en) * process of image copying should abort on error With this changes I'd like to point your attention at two things: 1. Now it's possible to create "en" directory for images which are required only for English language. Build process will not install this images if "en" it not in ALL_LINGUAS 2. If you ever create new base images subdirectory (in other words subdirectory which is *not* $lang subdirectory) it's necessary to list that directory in IMAGE_DIRS inside Makefile.am. This change I've documented in README (another patch in attachment)
Thanks Peter. The workaround of saving English images in it's seperate directory makes no sense to me. We use English as a fallback anyways, so including them is the way to go. The only problem we now have is the point, that the 'find' command on OS X doesn't honour -wholename. Would it be possible to use a similar option?
--> CONFIRMED
Roman: Sorry I was not clear about -wholename here, see mailing list for more details. Current implementation does not use -wholename. :)
Ow - you made the patch against Makefile.am revision 1583. Have to test it with this revision...
This patch seems to work now. I'll check it in. -> assign
patch applied with revision 1694. Thanks Peter! -> fixed